Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase fee limit for accounting data filter. #6674

Merged
merged 1 commit into from
May 3, 2023
Merged

Increase fee limit for accounting data filter. #6674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions core/src/main/java/bisq/core/dao/burningman/accounting/node/full/AccountingBlockParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,19 +114,17 @@ private Optional<AccountingTx> toAccountingTx(TempAccountingTx tempAccountingTx,
// Address check is done in parse method above already.
// Amounts are in a certain range but as fee can change with DAO param changes we cannot set hard limits.
// The min. trade fee in Nov. 2022 is 5000 sat. We use 2500 as lower bound.
// The largest taker fee for a 2 BTC trade is about 0.0059976 BTC (599_760 sat). We use 1_000_000 sat as upper bound.
// The largest taker fee for a 2 BTC trade is about 0.023 BTC (2_300_000 sat).
// We use 10_000_000 sat as upper bound to give some headroom for future fee increase and to cover some
// exceptions like SiaCoin having a 4 BTC limit.
// Inputs are not constrained.
// Max fees amount is currently 0.0176 BTC.
// We give some extra headroom to cover potential future fee changes.
// We store value as integer in protobuf to safe space, so max. possible value is 21.47483647 BTC.
long maxTradeFeeValue = Coin.parseCoin("0.1").getValue();
TempAccountingTxOutput firstOutput = outputs.get(0);
if (outputs.size() >= 2 &&
outputs.size() <= 3 &&
firstOutput.getValue() > 2500 &&
firstOutput.getValue() < 1_000_000 &&
isExpectedScriptType(firstOutput, tempAccountingTx) &&
firstOutput.getValue() <= maxTradeFeeValue) {
firstOutput.getValue() < 10_000_000 &&
isExpectedScriptType(firstOutput, tempAccountingTx)) {
// We only keep first output.
String name = burningManNameByAddress.get(firstOutput.getAddress());
return Optional.of(new AccountingTx(AccountingTx.Type.BTC_TRADE_FEE_TX,
Expand Down