Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: gettransactions method #6680

Merged
merged 2 commits into from
Jun 20, 2023
Merged

API: gettransactions method #6680

merged 2 commits into from
Jun 20, 2023

Conversation

helixx87
Copy link
Contributor

@helixx87 helixx87 commented May 6, 2023 

./bisq-cli --password=xyz gettransactions

alvasw
alvasw suggested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

cli/src/main/java/bisq/cli/table/builder/TransactionTableBuilder.java Outdated Show resolved Hide resolved
core/src/main/java/bisq/core/api/CoreWalletsService.java Outdated Show resolved Hide resolved
@helixx87 helixx87 force-pushed the api-gettransactions branch from c4cd62a to b96caa5 Compare May 20, 2023 08:30
@helixx87 helixx87 requested a review from alvasw May 20, 2023 08:32
@helixx87
Copy link
Contributor Author

Thanks @alvasw for review and valuable suggestions regarding code quality. I introduced them here using git commit --amend.

alvasw
alvasw suggested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me! 👍

When I run bisq-cli --help, I cannot find the gettransactions method in the list.

gettxfeerate                                                                 Get current tx fee rate in sats/byte

settxfeerate             --tx-fee-rate=<sats/byte>                           Set custom tx fee rate in sats/byte

unsettxfeerate                                                               Unset custom tx fee rate

gettransaction           --transaction-id=<transaction-id>                   Get transaction with id

createoffer              --payment-account=<payment-account-id> \            Create and place an offer
                         --direction=<buy|sell> \                            
                         --currency-code=<currency-code> \                   
                         --amount=<btc-amount> \

@helixx87 helixx87 force-pushed the api-gettransactions branch from b96caa5 to 9087e55 Compare June 8, 2023 08:32
@helixx87 helixx87 requested a review from alvasw June 8, 2023 08:33
alvasw
alvasw approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alejandrogarcia83
alejandrogarcia83 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 3620803 into bisq-network:master Jun 20, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.11 milestone Jun 20, 2023
@alvasw alvasw mentioned this pull request Jul 17, 2023
Closed
@helixx87 helixx87 mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

@alvasw alvasw alvasw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.11
Development

Successfully merging this pull request may close these issues.
3 participants
@helixx87 @alvasw @alejandrogarcia83