-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new burningman accounting file recreated from scratch. #6740
Use new burningman accounting file recreated from scratch. #6740
Conversation
Remove old file. The current accounting data are missing about 10% of transactions due to threading issues at processing the transactions in earlier versions.
e2b6d4a
to
16bbef9
Compare
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
The numbers are close to the values from my full node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BM BTC received amount shown is slightly higher than the real amount received. Any ideas why?
Have you checked if there was payments to the Bisq internal addresses (either BTC or BSQ wallet). |
It seems to be this. A BMs receiver address is sometimes chosen from a seemingly random DAO comp cycle. In my case from cycle 36 and 41. Only 2 transactions out of several thousand, all the rest went to the specified custom address. I checked some other BM and they exhibit the same quirk. Not related to this particular PR though. |
I guess that can happen for trade fees if users do not have the correct DAO data (comp request with the external address). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
PR bisq-network#6740 was a diff against master (instead against the release/v1.9.11 branch). The previous merge into the release branch corrupted the acounting file.
PR bisq-network#6740 was a diff against master (instead against the release/v1.9.11 branch). The previous merge into the release branch corrupted the acounting file.
Use new burningman accounting file recreated from scratch.
Remove old file.
The current accounting data are missing about 10% of transactions due to threading issues at processing the transactions in earlier versions.