Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: Implement JDepsTask for jlink and jpackage #6826

Merged
merged 2 commits into from
Aug 24, 2023
Merged

packaging: Implement JDepsTask for jlink and jpackage #6826

merged 2 commits into from
Aug 24, 2023

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Aug 23, 2023

alejandrogarcia83
alejandrogarcia83 previously approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw dismissed alejandrogarcia83’s stale review August 23, 2023 23:58

The merge-base changed after approval.

alejandrogarcia83
alejandrogarcia83 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit e5f4a88 into bisq-network:master Aug 24, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Aug 24, 2023
@alvasw alvasw mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.14
Development

Successfully merging this pull request may close these issues.
2 participants
@alvasw @alejandrogarcia83