Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pix payment account, add HolderName #6965

Merged
merged 1 commit into from Dec 20, 2023
Merged

Update Pix payment account, add HolderName #6965

merged 1 commit into from Dec 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2023

  • Add HolderName, mandatory for new accounts.
  • Older, existing Pix accounts do not have HolderName, and retain their age status.
  • If buying from an old account that does not have HolderName, Trader Chat can be used.

@pazza83

pix1

pix2

pix3

HenrikJannsen
HenrikJannsen approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Maybe add comments as mentioned on the other PR

@ghost ghost mentioned this pull request Dec 16, 2023
Merged
@ghost
Copy link
Author

ghost commented Dec 16, 2023

Code comments added, per code review.

HenrikJannsen
HenrikJannsen approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alejandrogarcia83
alejandrogarcia83 previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost ghost dismissed alejandrogarcia83’s stale review December 20, 2023 05:03

The merge-base changed after approval.

alejandrogarcia83
alejandrogarcia83 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 70a15ce into bisq-network:master Dec 20, 2023
6 checks passed
This was referenced Dec 24, 2023
Closed
Closed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Dec 31, 2023
@alvasw alvasw mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.15
Development

Successfully merging this pull request may close these issues.
2 participants
@HenrikJannsen @alejandrogarcia83