Reduce log level of two messages which frequently fill user's log. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisq can get into a state where it checks for network peers constantly, filling the logs with the connection attempts. e.g. Peer discovery didn't provide us any more peers, will try again in 10000ms According to the log message, there should be a 10000ms delay between connection attempts, but examples clearly contradict this. The problem with these messages spamming all 20 logfiles is that it prevents other, valid trade issues from being investigated. A high percentage of supplied user logs contain examples of this. I'm hoping this can be fixed in Bisq's fork of BitcoinJ.
|
This would be really great to get fixed. Sometimes when a user is having issues with an open trade on Bisq they have to rely on being able to provide their logs to support so a delayed payout for the trade can be created. If the user ends of providing logs with multiple 10000ms delay messages it ends up filling up their logs and reduces the chance of being able to ascertain the delayed payout information needed to send the BTC from the trade multisig to the donation address. |
|
You could do it also via the logback file |
ghost
mentioned this pull request
|
utACK @gabernard Could you merge this, please? |
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bisq can get into a state where it checks for network peers constantly, filling the logs with the connection attempts. e.g. Peer discovery didn't provide us any more peers, will try again in 10000ms According to the log message, there should be a 10000ms delay between connection attempts, but examples clearly contradict this. The problem with these messages spamming all 20 logfiles is that it prevents other, valid trade issues from being investigated. A high percentage of supplied user logs contain examples of this. I'm hoping this can be fixed in Bisq's fork of BitcoinJ.
Fixes bisq-network/bisq#5996