Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 47 #1295

Closed
alvasw opened this issue May 13, 2023 · 4 comments
Closed

For Cycle 47 #1295

alvasw opened this issue May 13, 2023 · 4 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented May 13, 2023

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 9302.33
  • USD requested: 8000
  • BSQ rate: 0.86 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 46 #1276

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
OfferUtilTest: Remove broken testGetRandomOfferId test dev bisq-network/bisq#6652
Add bisq2 Gradle Tor Plugin dev bisq-network/bisq#6676
  • Add bisq2 gradle-tasks module
  • Add bisq2 Gradle Tor Plugin
Remove empty VerifyTaskTest class dev bisq-network/bisq#6682
Common: Reformat MathUtilsTest dev bisq-network/bisq#6683
CI: Enable build scans dev bisq-network/bisq#6684
  • Accept Gradle terms if buildScan property set by developer
  • GitHub Actions: Publish Gradle build scan
GitHub Actions: Run on all branches dev bisq-network/bisq#6685
Move JUnit dependency definition to bisq.java-conventions dev bisq-network/bisq#6686
Move hamcrest dependency definition to bisq.java-conventions dev bisq-network/bisq#6687
Move mockito dependency definition to bisq.java-conventions dev bisq-network/bisq#6688
core: Fix broken PriceTest.testParse test dev bisq-network/bisq#6691
core: Fix broken CoinUtilTest.testGetAdjustedAmount dev bisq-network/bisq#6692
Fix broken P2PDataStoragePersistableNetworkPayloadTest dev bisq-network/bisq#6693
Fix broken ProtectedStorageEntryTest dev bisq-network/bisq#6694
Re-enable all tests dev bisq-network/bisq#6695
Centralize Gradle Test Setup dev bisq-network/bisq#6696
  • Remove redundant 'testRuntimeOnly libs.junit.jupiter.engine'
  • Remove redundant 'useJUnitPlatform()' declarations
Add org.bouncycastle:bcpg-jdk15on to version catalog dev bisq-network/bisq2#744
ServerChannel: Don't set serverSocketChannel to non-blocking dev bisq-network/bisq2#749 The InboundConnectionsManager sets the serverSocketChannel to non-blocking mode in registerOpAccept().
Fix InboundConnections message receival dev bisq-network/bisq2#750
OutboundConMultiplexer: Add active connections to idle check dev bisq-network/bisq2#751
InboundConnectionsManager: Log IOException on connection failure dev bisq-network/bisq2#752
OutboundConnectionsManager: Log IOException on connection failure dev bisq-network/bisq2#753
build-logic: Create gradle-tasks module dev bisq-network/bisq2#754
build-logic: Move DownloadTask to gradle-tasks module dev bisq-network/bisq2#755
DownloadTask: Pass outputFile lazily to task dev bisq-network/bisq2#756
DownloadTask: Delegate UP-TO-DATE checks to Gradle dev bisq-network/bisq2#760
Implement per-transport SocketChannelFactory dev bisq-network/bisq2#762
Implement TorServerSocketChannel dev bisq-network/bisq2#763
Switch to NIO implementation dev bisq-network/bisq2#764
build-logic: Remove Electrum binary hash extension dev bisq-network/bisq2#767
build-logic: Move OS class to gradle-tasks module dev bisq-network/bisq2#768
build-logic: Implement PerOsUrlProvider dev bisq-network/bisq2#769
build-logic: Move FileVerificationTask to gradle-tasks dev bisq-network/bisq2#770
build-logic: Pass URL instances to DownloadTask dev bisq-network/bisq2#771
Rename FileVerificationTask to SignatureVerificationTask dev bisq-network/bisq2#772
build-logic: Implement generic SignedBinaryDownloader dev bisq-network/bisq2#773
DownloadTaskFactory: Fix loss of filename due to lazy init dev bisq-network/bisq2#776
SignatureVerification: Support PGP subkeys dev bisq-network/bisq2#777
  • Parse masterkey and subkeys from PGP file
  • Verify masterkey fingerprint and subkey signatures
  • Use all keys to verify signature
Implement TorBinaryDownloader Gradle Plugin dev bisq-network/bisq2#779 The BisqTorBinaryPlugin downloads, verifies and re-packages the Tor binary.
OutboundConnMultiplex: Use selector to sychronize threads dev bisq-network/bisq2#780
Revert "Switch to NIO implementation" dev bisq-network/bisq2#782
Implement generic ZipFileExtractor dev bisq-network/bisq2#810
Use new tor binary from Gradle plugin dev bisq-network/bisq2#811
Tor: Remove dependency to old binary dev bisq-network/bisq2#812
Electrum: Remove unused libraries dev bisq-network/bisq2#815
  • Electrum Gradle: Remove libs.google.guava dependency
  • Electrum Gradle: Remove libs.bouncycastle.pg dependency
Tor: Remove libs.apache.commons.compress dependency dev bisq-network/bisq2#817
PGP: Move normalize fingerprint to gradle-tasks module dev bisq-network/bisq2#818
ExtractElectrumDmg: Remove unused CMD_TIMEOUT field dev bisq-network/bisq2#819
ElectrumPackager: Rename registerVerifiedElectrumBinary() dev bisq-network/bisq2#821
ElectrumExtractor: Switch to ZipFileExtractor dev bisq-network/bisq2#822
ZipExtractor: Remove conditional extraction dev bisq-network/bisq2#825 We don't need the conditional extraction, because the zip file doesn't contain all electrum binaries (for all OSes) anymore.
dev 8000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels May 13, 2023
@MwithM MwithM added this to the Cycle 47 milestone May 13, 2023
@alvasw
Copy link
Author

alvasw commented May 17, 2023

a2f4390466147014268b3f488752aa5da6302713a895a5a009a34cc3147431e1

@ripcurlx
Copy link
Contributor

Sorry about my absence this cycle and not reviewing all dev CRs. As dev team lead I approve this CR for dev.

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label May 28, 2023
@ghost
Copy link

ghost commented May 28, 2023

Issuance by Team:

team amount BSQ amount USD
dev 9302.33 8000.00

Total Issuance: 9302.33 BSQ (equivalent to: 8000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented May 28, 2023

Closed as accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

3 participants