Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OfferUtilTest: Remove broken testGetRandomOfferId test #6652

Merged
merged 1 commit into from
Apr 17, 2023
Merged

OfferUtilTest: Remove broken testGetRandomOfferId test #6652

merged 1 commit into from
Apr 17, 2023

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Apr 17, 2023

No description provided.

@alvasw
Copy link
Contributor Author

alvasw commented Apr 17, 2023

@alejandrogarcia83 This test caused the build failures when you tried to merge the release branch.

alejandrogarcia83
alejandrogarcia83 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Thank you!

@alejandrogarcia83 alejandrogarcia83 merged commit 3f584e3 into bisq-network:master Apr 17, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.11 milestone Apr 17, 2023
@alvasw alvasw deleted the remove_broken_offer_util_test_test_get_random_offer_id branch May 9, 2023 11:26
@alvasw alvasw mentioned this pull request May 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.11
Development

Successfully merging this pull request may close these issues.
2 participants
@alvasw @alejandrogarcia83