Fix #1321: Settings GUI: "Save password to Keyring" was disabled #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to "no appropriate keyring found" * Add more DEBUG output to tools.keyringSupported() * Add "keyring-supported" to "--diagnostics" output
|
Awesome, thanks for the thorough work :) Would you like to include/link your upcoming patch file or hotfix instructions in README as well? Or is this PR totally ready to commit? |
|
This PR is ready to commit! I want to "hide" the patch in the issue since we do not want to support back-ports but some maintainers may want to do this. The "how to fix" doc is only meant for configuring a supported backend class... The patch file is in work and scheduled for tomorrow :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to "no appropriate keyring found"
keyringto README.md