Test backing up permissions in a "SSH local" profile. #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing class `test_snapshots.py::TestSshPermissions` testing `snapshots.py::Snapshot.backupPermissions()` in a "SSH local" environment. The case was untested before. Especially it is needed to support the fix of #1247 (rsync incompatibility). I slightly improved the method `Snapshots.backupPermissions()` because before it was silent and didn't care about if the used `rsync` call succeeded or not. No the return code of `rsync` is returned and can be used in a unittest. The "helper" functions in `test_snapshots.py` are refactored and improved a bit. Now they are used by this new `TestSshPermissions` and the before introduced `TestSshRemoveSnapshot` tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing class
test_snapshots.py::TestSshPermissionstestingsnapshots.py::Snapshot.backupPermissions()in a "SSH local" environment.The case was untested before. Especially it is needed to support the fix of #1247 (rsync incompatibility).
I slightly improved the method
Snapshots.backupPermissions()because before it was silent and didn't care about if the usedrsynccall succeeded or not. No the return code ofrsyncis returned and can be used in a unittest.The "helper" functions in
test_snapshots.pyare refactored and improved a bit. Now they are used by this newTestSshPermissionsand the before introducedTestSshRemoveSnapshottests.