Build: Simple unit tests about UserCallbackPlugin #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests to UserCallbackPlugin (behavior coverage incomplete).
In short: These tests simply testing if the callback() method is called with the correct values (reason code for example).
This is a side-product of my investigation about the plugin manager and user-callback in context of PR #1269. The value of that tests is low and they are not robust against refactoring. I added some thoughts and learning's into the code comments.
I tried to not to touch the productive code. Because of that there are some not so nice workarounds in the test code.
More comments in PR #1269.