refactor: Extract and decouple cron-related code from config.py and tools.py #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buhtz
added
the
PR: Merge after creative-break
buhtz
changed the title
Closed
This was referenced Jun 10, 2024
buhtz
added a commit
that referenced
this pull request
Jun 15, 2024
Warn if no Cron instance is running. The list of processes running on the system are grepped case-insensitive for the string `cron`. That would catch cronie, fcron and similar cron derivatives. This will help especially on Arch-based system often installing cron but not enabling it. Additionally modified TravisCI to use the oldest supported Python version (3.8) only. This will save credits on TravisCI. Also upgraded Ubuntu from Focal (20.04 LTS) to Jammy (22.04 LTS). Fix a minor bug introduced via #1747. Fix #1741 Fix #1765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved code related to crontab handling from config.py and tools.py into its own module schedule.py.
Added some new tests and rearranged some tests. Refactored the related code.
Removed some deprecated code related to the year 2014 when BIT dropped the use of anacron and starting to imitated the anacron behavior by its own.