-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lint): W0611 (unused imports) #1775
fix(lint): W0611 (unused imports) #1775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Manuel,
On behalf of the team, thank you for your contribution and taking
the time to improve Back In Time. We appreciate it.
Your PR looks fine. It will get merged after a cool off period. To find out how we usually tread PRs please read "What happens after you opened a Pull Request (PR)?".
Best,
Christian
Hello Manual, My stomach tells me ~10 files are OK. 25 errors are Ok. Fix them all if you want. You don't have to create a new PR for this. Just work further on your existing branch. Commit and push. This PR will be updated automatically. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just added some minor suggestions and modifications.
Hello Manuel, To my understanding, knowledge and experience I see no real problem or real risk with cleaning up the unused imports. But it is also my experience that I am often wrong with assumptions like this. 😆 Because of that I would like to put your PR on hold until the upcoming release is out and merge it after that. Best, |
Hi Christian, sure I totally understand that. This is not just your experience 😁 Regards, Manuel |
Removed the unused imports from the files config.py, encfstoos.py and passwd.py.
This reduces the number of unused imports (W0611) from 28 to 23.