Add n16939 #38
Merged
Add n16939 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Concept ACK. Do you mind if I host this one? I'll try to get notes and questions up by Monday night. |
|
Sounds good, looking forward to it! |
|
I've added notes and questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes one possible PR for the Review Club PRs. That said, we've done several p2p PRs lately and it could be time to look at a different type of PR.
This one actually involves reviewing two short PRs, one merged and one open, by sipa and ajtowns. Is there a bug to be fixed? You make the call.
The host would need to be filled in and the notes are only preliminary.