Skip to content

Commit

Permalink
Merge bitcoin/bitcoin#31396: test: simple reordering to reduce run time
Browse files Browse the repository at this point in the history
62f6d9e test: simple ordering optimization to reduce runtime (tdb3)

Pull request description:

  Noticed in #31371 that the position of `mempool_ephemeral_dust` within `BASE_SCRIPTS` was lengthening total test runtime. Instead of moving only that test, looked for others to move to reduce runtime.

  This is a quick optimization that was found to reduce overall functional test runtime of up to around 20% (depending on jobs and machine characteristics). Since it seems like test ordering could be done in many different ways, with many variables, and bike shedding could creep in, a relatively straightforward approach was taken for now that minimized changes to test_runner.

ACKs for top commit:
  maflcko:
    lgtm ACK 62f6d9e
  TheCharlatan:
    ACK 62f6d9e

Tree-SHA512: 6f93fbe4de3fce202383d9f84aa0e96961af3de3c02b8cab73589339d701f32c5e1b57a191eeebf4b06b5cd7a82617f63f24110732940be1a5a4d9237813a570
  • Loading branch information
fanquake committed Dec 2, 2024
2 parents a25b892 + 62f6d9e commit e043618
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/functional/test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@
'feature_fee_estimation.py',
'feature_taproot.py',
'feature_block.py',
'mempool_ephemeral_dust.py',
'wallet_conflicts.py --legacy-wallet',
'wallet_conflicts.py --descriptors',
'p2p_opportunistic_1p1c.py',
'p2p_node_network_limited.py --v1transport',
'p2p_node_network_limited.py --v2transport',
# vv Tests less than 2m vv
Expand Down Expand Up @@ -146,6 +150,7 @@
'p2p_feefilter.py',
'feature_csv_activation.py',
'p2p_sendheaders.py',
'feature_config_args.py',
'wallet_listtransactions.py --legacy-wallet',
'wallet_listtransactions.py --descriptors',
'wallet_miniscript.py --descriptors',
Expand Down Expand Up @@ -199,7 +204,6 @@
'rpc_getchaintips.py',
'rpc_misc.py',
'p2p_1p1c_network.py',
'p2p_opportunistic_1p1c.py',
'interface_rest.py',
'mempool_spend_coinbase.py',
'wallet_avoid_mixing_output_types.py --descriptors',
Expand All @@ -214,8 +218,6 @@
'wallet_reindex.py --legacy-wallet',
'wallet_reindex.py --descriptors',
'wallet_reorgsrestore.py',
'wallet_conflicts.py --legacy-wallet',
'wallet_conflicts.py --descriptors',
'interface_http.py',
'interface_rpc.py',
'interface_usdt_coinselection.py',
Expand Down Expand Up @@ -395,13 +397,11 @@
'feature_remove_pruned_files_on_startup.py',
'p2p_i2p_ports.py',
'p2p_i2p_sessions.py',
'feature_config_args.py',
'feature_presegwit_node_upgrade.py',
'feature_settings.py',
'rpc_getdescriptorinfo.py',
'rpc_mempool_info.py',
'rpc_help.py',
'mempool_ephemeral_dust.py',
'p2p_handshake.py',
'p2p_handshake.py --v2transport',
'feature_dirsymlinks.py',
Expand Down

0 comments on commit e043618

Please sign in to comment.