Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.21.1 Recent transactions tab expands entire window beyond screen resolution #373

Closed
fanquake opened this issue Jun 28, 2021 · 0 comments · Fixed by #365
Closed

0.21.1 Recent transactions tab expands entire window beyond screen resolution #373

fanquake opened this issue Jun 28, 2021 · 0 comments · Fixed by #365
Labels
Bug Something isn't working

Comments

@fanquake
Copy link
Member

(Moved from bitcoin/bitcoin#22246)

When a transaction is displayed in the Overview window on Bitcoin Core 0.21.1, the entire window stretches beyond the screen resolution depending on how many recipients there are in the transaction, even when not focuses on the Overview page. 1-recipient transactions inappropriately expand longer than normal but are still visible in its entirety, but 2 or more recipient transitions expand the tab - and the entire window with it - towards the right. Shrinking the window horizontally is disabled.

Expected behavior

The transaction tuple is truncated according to the window size with a maximum length computed for the "recent transactions":

(0.21.0 behavior): bitcoin core 0.21.0

First transaction is a 1-recipient transaction, second one is a 2-recepient transaction and the rest are blocks mined from regtest -generate. They are truncated if they are larger than the Qt tab size for "recent transactions"

Actual behavior

There is no limit to the length of the recent transactions tab and it forces the horizontal dimension of the window to be exactly the size of the longest transaction tuple listed in the recent transactions tab.

(0.21.1 behavior): bitcoin core 0.21.1

The mined blocks transactions fit, but the 1-recipient transaction and the 2-receipient transaction stretch too far to the right, as if a size limit was not being set for the tab.

To reproduce

This issue can be consistently reproduced.

  • Start bitcoind in regtest and in another terminal run bitcoin-cli --regtest -generate 110 (this is to create bitcoins needed to make the problem transactions)
  • Shut down bitcoind and open bitcoin-qt in regtest
  • Generate two receiving addresses using Receive > Create New Receiving Address
  • Go to the Send tab, add two receiving address and send them an arbitrary amount of BTC in a single transaction and press Send (the amount is irrelevant)

(at this point you may create another transaction to any address using one receiving address if you want, to compare the difference)

  • Switch to Overview Tab to view the non-truncated transactions. Note that the window will already appear expanded if you simply open a wallet with such transactions.

System information

Bitcoin core 0.21.1 precompiled from bitcoincore.org, Linux KDE5 Ubuntu 20.04 running Qt 5.9.8, display resolution 1366x768

@fanquake fanquake added the Bug Something isn't working label Jun 28, 2021
@fanquake fanquake linked a pull request Jun 28, 2021 that will close this issue
@hebasto hebasto closed this as completed in 484d4ee Jul 5, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Jul 5, 2021
…-only addresses

cd46c11 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov)
9ea1da6 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov)

Pull request description:

  This PR guaranties that the "eye" sign won't be hidden for very long addresses/labels.

  No longer need to extend `TransactionOverviewWidget` widget width to make "eye" signs shown:

  ![Screenshot from 2021-06-15 00-21-05](https://user-images.githubusercontent.com/32963518/121961807-9123b600-cd70-11eb-8cdd-8b2b0d1bf44f.png)

  Fixes bitcoin-core/gui#373

ACKs for top commit:
  jarolrod:
    ACK cd46c11

Tree-SHA512: 0602b5bb65d53c5b18e86260750006bba03adbae181917b5a2b7f89b17290bd1f57b4f80adaba32f42cc6fb468598a888b12c0b6b09005d2f2c07bd4d1ad334a
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
knst pushed a commit to knst/dash that referenced this issue Oct 11, 2024
…-only addresses

cd46c11 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov)
9ea1da6 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov)

Pull request description:

  This PR guaranties that the "eye" sign won't be hidden for very long addresses/labels.

  No longer need to extend `TransactionOverviewWidget` widget width to make "eye" signs shown:

  ![Screenshot from 2021-06-15 00-21-05](https://user-images.githubusercontent.com/32963518/121961807-9123b600-cd70-11eb-8cdd-8b2b0d1bf44f.png)

  Fixes bitcoin-core/gui#373

ACKs for top commit:
  jarolrod:
    ACK cd46c11

Tree-SHA512: 0602b5bb65d53c5b18e86260750006bba03adbae181917b5a2b7f89b17290bd1f57b4f80adaba32f42cc6fb468598a888b12c0b6b09005d2f2c07bd4d1ad334a
knst pushed a commit to knst/dash that referenced this issue Oct 24, 2024
…-only addresses

cd46c11 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov)
9ea1da6 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov)

Pull request description:

  This PR guaranties that the "eye" sign won't be hidden for very long addresses/labels.

  No longer need to extend `TransactionOverviewWidget` widget width to make "eye" signs shown:

  ![Screenshot from 2021-06-15 00-21-05](https://user-images.githubusercontent.com/32963518/121961807-9123b600-cd70-11eb-8cdd-8b2b0d1bf44f.png)

  Fixes bitcoin-core/gui#373

ACKs for top commit:
  jarolrod:
    ACK cd46c11

Tree-SHA512: 0602b5bb65d53c5b18e86260750006bba03adbae181917b5a2b7f89b17290bd1f57b4f80adaba32f42cc6fb468598a888b12c0b6b09005d2f2c07bd4d1ad334a
knst pushed a commit to knst/dash that referenced this issue Oct 24, 2024
…-only addresses

cd46c11 qt: Draw "eye" sign at the beginning of watch-only addresses (Hennadii Stepanov)
9ea1da6 qt: Do not extend recent transaction width to address/label string (Hennadii Stepanov)

Pull request description:

  This PR guaranties that the "eye" sign won't be hidden for very long addresses/labels.

  No longer need to extend `TransactionOverviewWidget` widget width to make "eye" signs shown:

  ![Screenshot from 2021-06-15 00-21-05](https://user-images.githubusercontent.com/32963518/121961807-9123b600-cd70-11eb-8cdd-8b2b0d1bf44f.png)

  Fixes bitcoin-core/gui#373

ACKs for top commit:
  jarolrod:
    ACK cd46c11

Tree-SHA512: 0602b5bb65d53c5b18e86260750006bba03adbae181917b5a2b7f89b17290bd1f57b4f80adaba32f42cc6fb468598a888b12c0b6b09005d2f2c07bd4d1ad334a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant