Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RPC console welcome message translation-friendly #331

Merged
merged 1 commit into from
May 31, 2021
Merged

Make RPC console welcome message translation-friendly #331

merged 1 commit into from
May 31, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 15, 2021

The best practice is do not split a translatable multi-line message into single lines. This helps translators to follow the context.

jarolrod
jarolrod reviewed May 15, 2021
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved
src/qt/rpcconsole.cpp Show resolved Hide resolved
src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved
@hebasto
Copy link
Member Author

hebasto commented May 15, 2021

Updated b00aaf6 -> a596381 (pr331.01 -> pr331.02, diff):

jarolrod
jarolrod reviewed May 15, 2021
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a596381

@jarolrod jarolrod mentioned this pull request May 19, 2021
Merged
@hebasto
Copy link
Member Author

hebasto commented May 19, 2021

Updated a596381 -> 67bef11 (pr331.02 -> pr331.03, diff):

Seeing no reason to use QString optimization tricks as the welcome_message is static now.

@jarolrod
Copy link
Member

re-ACK 67bef11

@hebasto
Copy link
Member Author

hebasto commented May 20, 2021

Rebased 67bef11 -> 0f3d955 (pr331.03 -> pr331.04) due to the conflict with #281.

@jarolrod
Copy link
Member

jarolrod commented May 21, 2021 •
edited
Loading

re-ACK 0f3d955

Screenshots to show that there is no change in the presentation of the welcome message (% new comma for grammar):

Master PR (0f3d955)
Screen Shot 2021-05-29 at 7 21 35 PM Screen Shot 2021-05-29 at 7 25 23 PM

@hebasto
Copy link
Member Author

hebasto commented May 29, 2021

@goums @Talkless Do you mind reviewing this PR?

@hebasto hebasto requested a review from jonatack May 29, 2021 12:10
@hebasto hebasto merged commit aedf71d into bitcoin-core:master May 31, 2021
@hebasto hebasto deleted the 210515-welcome branch May 31, 2021 20:45
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 1, 2021
@hebasto
Merge bitcoin-core/gui#331: Make RPC console welcome message translat…
df929d8 
…ion-friendly

0f3d955 qt: Make RPC console welcome message translation-friendly (Hennadii Stepanov)

Pull request description:

  The best practice is do not split a translatable multi-line message into single lines. This helps translators to follow the context.

ACKs for top commit:
  jarolrod:
    re-ACK 0f3d955

Tree-SHA512: 30911ff3a972a7787804bb8b27d0b77bfff15939bb478c199261866bfb55d9acd12ab4d44b8b9fc1d4898222cabc4007cc897f9b65728924d121f31e914c44ac
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge aedf71d into merged_master (Bitcoin PR bitcoin-core/gui#331)
7f55243
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jarolrod jarolrod jarolrod left review comments

@jonatack jonatack Awaiting requested review from jonatack

Assignees
No one assigned
Labels
Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @jarolrod @DrahtBot