Do not truncate node flag strings in debugwindow peers details tab

[Saibato]

Fix: When fiddling around with new node flags other than the usual.

I saw that not all possible node flag strings i.e. the UNKNOWN[..] where
visible in peers details tab.
Since v18.2 fixed size was set to 300 and sliding is thereby limited.

A fix on my old linux cruft and small screen was to set minimumSize width to -1 or 0.
Qt will then autosize the slider to the max string length.

Thereby i had full display of all flags inclusive sliding without to fullscreen the window.

Not sure if this is even an issue for those who can afford big screens or high res macs?
Feedback welcome.

BTW: nice side effect now again easy to scroll trough long version names of the node.
can't wait to see strings like /Satoshi:0.23.99/NOX2NOX4NOX32 or what ever fits in the version string.

[hebasto]

Welcome @Saibato! Mind attaching some screenshots?

[Saibato]

Welcome @Saibato! Mind attaching some screenshots?

@hebasto here some screenshots. 👍
hope that new slider visible in maximize and full left shift of details in second picture is visible on github . Pls ping me for more pictures.
The string was
Services NETWORK & GETUTXO & BLOOM & WITNESS & UNKNOWN[2^6] & UNKNOWN[2^7] & NETWORK_LIMITED
Before the change after the & it stopped.

Before change ( we had no slider on bottom since max 300) impossible to see all strings

**After change ( we have now 2 sliders on bottom) second for detail
You now can slide through the details strings **.

Now even there in small window, full scroll is possible.

Here some more pictures with small size window.
Now even there full scroll is possible.

[hebasto]

Concept ACK.

[hebasto]

It seems the PR title (and the commit message) is misleading a bit as the horizontal slider is not disabled on master (dbd7a91):

[Saibato]

It seems the PR title (and the commit message) is misleading a bit as the horizontal slider is not disabled on master

... when set fixed sliding is thereby limited.
In small windows the string is truncated at some point and no further sliding is possible.
And in full size window, the slider vanish and the rest of the string is truncated.

The topic i saw was discussed in bitcoin/bitcoin#15136

... you can adjust a view by moving QSplitter bar (marked by a dot on your screenshot) and window borders:

But that fall short with long strings.

The tile .. autosize display .. I used to reflect the fact that with this change the size is adapted to the string and not fixed to a maximum depending on the whole window size-400 AFAICT

How about "qt;Adapt debugwindow peers details slider view to the peers actual used flags list string size" ?

Please hint to me alternative wording, to reflect the full impact of this one-liner

[hebasto]

Moreover, for the detailWidget the default values of properties geometry and minimumSize are ok, i.e., a bunch of lines could be just removed:

--- a/src/qt/forms/debugwindow.ui
+++ b/src/qt/forms/debugwindow.ui
@@ -1070,20 +1070,6 @@
               <bool>true</bool>
              </property>
              <widget class="QWidget" name="detailWidget">
-              <property name="geometry">
-               <rect>
-                <x>0</x>
-                <y>0</y>
-                <width>300</width>
-                <height>426</height>
-               </rect>
-              </property>
-              <property name="minimumSize">
-               <size>
-                <width>300</width>
-                <height>0</height>
-               </size>
-              </property>
               <layout class="QGridLayout" name="gridLayout_2" columnstretch="0,1">
                <item row="0" column="0">
                 <widget class="QLabel" name="label_30">

[Saibato]

Hmm works too ,,, but a i kinda like short changes.
and b when edit with Qt designer the ui file, the default is to have at least a
<property name="geometry">
So for now i like to stay a bit conservative, since i can not test easy outside my cruft.
so how about this?

diff --git a/src/qt/forms/debugwindow.ui b/src/qt/forms/debugwindow.ui
index 8b7080083..1217ca3e2 100644
--- a/src/qt/forms/debugwindow.ui
+++ b/src/qt/forms/debugwindow.ui
@@ -1078,12 +1078,6 @@
                 <height>426</height>
                </rect>
               </property>
-              <property name="minimumSize">
-               <size>
-                <width>300</width>
-                <height>0</height>
-               </size>
-              </property>
               <layout class="QGridLayout" name="gridLayout_2" columnstretch="0,1">
                <item row="0" column="0">
                 <widget class="QLabel" name="label_30">


I have written a shorty test script to test long flag lists, by spawn up 2 connected
 regtest nodes. 

``` bash
#!/bin/bash
params="-regtest -debug=1"
makeflags=-j4 
dir=/tmp/bitcoin-test
baseport=1234
testfix=0 #if 1 auto git pull the gui fix from Saibato PR #6 https://github.com/bitcoin-core/gui/commit/099defc58975e2ec0e8069b84cf852f7673122dd

if [ $testfix = 1 ]; then git pull --no-edit https://github.com/Saibato/gui fix-qt-disp-flags ;fi

t=$(echo "")
for i in {1..8} # number of flags to set active ( max 64 )
 do t+=$(echo "|(1<<$i)")
done

#Next change init.cpp to set many flags 
 
sed -i "s/ServiceFlags(NODE_NETWORK | NODE_NETWORK_LIMITED);/ServiceFlags(NODE_NETWORK | NODE_NETWORK_LIMITED $t);/g" ./src/init.cpp
#Now recompile the the code
make $makeflags

printf "######\n\n now wait for-torcontrol=127.0.0.1:9151 the nodes to spun up ...\ntest with window>Network Traffic>Peers\n######"

# now revert the set many node flags in init.cpp 
sed -i "s/ServiceFlags(NODE_NETWORK | NODE_NETWORK_LIMITED $t)/ServiceFlags(NODE_NETWORK | NODE_NETWORK_LIMITED)/g" ./src/init.cpp
if [ $testfix = 1 ]; then git reset --hard HEAD~1 ;fi

for i in 1 2
do port2=$((3-$i))
 rm -rf $dir$i && mkdir $dir$i
 ./src/qt/bitcoin-qt $params  -bind=127.0.0.1 $(if [ $i = 1 ]; then echo -server;fi) -wallet=test -listen -port=$(echo $baseport$i) -datadir=$dir$i -connect=127.0.0.1:$(echo $baseport$port2) &
done

[hebasto]

1ed063c LGTM

Mind squashing commits before the final review?

[hebasto]

ACK 0ac09c9, tested on Linux Mint 20 (x86_64, Qt 5.12.8).

[hebasto]

@promag @fanquake Mind reviewing this PR?

[flack]

Another idea might be to split the node flags into multiple lines, i.e.

NETWORK &
GETUTXO &
BLOOM &
...etc..

Then you could make the whole right panel smaller and have more space for the table

[hebasto]

@flack

Another idea might be to split the node flags into multiple lines, i.e.

NETWORK &
GETUTXO &
BLOOM &
...etc..

Then you could make the whole right panel smaller and have more space for the table

Your idea looks good, and I will happy to review the relevant PR.

This PR fixes widget layout and is an improvement.

[promag]

Tested ACK 0ac09c9 on macos.