Add Import to Wallet GUI

[KolbyML]

resolves #19

This PR does a few things

• Refactors importmulti and importdescripters RPC code
• Adds functions to interfaces
• Adds GUI's for importpubkey, importprivkey, importaddress, importmulti, and importdescriptors RPCs
• Adds QT Tests for all 5 import GUI's

Things to get this merged

• get the refactor merge on refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc bitcoin/bitcoin#26840
• after that is done I will split the GUI PR into (importpubkey, importprivkey, importaddress), importmulti, importdescriptors each PR will have its respective tests. I will rebase to remove the commit for the refactor in those PR's it is in this PR so people can test. This is for easier code review

The dialogs are located under File -> Import to Wallet...
The options vary based on what is supported with your specific wallet type.

Dialogs are Located	Import Public Key Dialog

Import Private Key Dialog	Import Address Dialog

Import Multi Dialog scriptPubKey Tab	Import Multi Dialog Descriptor Tab

Import Descriptors Dialog

For Range before I had a lineedit with placeholders begin and end, @achow101 suggested I used QSpinBox, but it doesn't have placeholder text. So Currently if both are default value it counts as no input. It would look very nice if I implemented a custom QAbstractSpinBox with placeholder text, but I am not sure if it is overkill for this PR.

[achow101]

While the imports mostly work, I noticed that there is no feedback when it is successful. What I expected to happen was a dialog indicating success, and then the import dialog would close itself too.

I think you should also look into adapting a couple of the importmulti tests to be GUI unit tests that can test these new dialogs. It would be very helpful to have some automated testing of all of the things here rather than trying to do it by hand.

Note: @KolbyML is my Summer of Bitcoin mentee.

[w0xlt]

Concept ACK.
Perhaps it would be better to split each menu item into its own PR.

[jarolrod]

Awesome first contribution @KolbyML, you're taking a big swing here! Concept ACK on adding this feature.

First, I would second @w0xlt suggestion of breaking each import into it's own PR, this makes the changes digestible for reviewers.

Second, please note that any changes to the code outside of src/qt (excluding necessary build changes to build any new ui files) cannot be merged from this repo. Any refactoring changes to code outside of src/qt you want to propose in order to make this gui feature work should be opened up in the main repo: https://github.com/bitcoin/bitcoin

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

[pablomartin4btc]

I'll review this as soon as I can, in the meantime, could you please link the PR to the existent issue? (Writing any of these keywords somewhere in the description followed by #19 would do the trick, thx!)

[KolbyML]

@pablomartin4btc sounds good I will try and get my 2 PR's rebased

[hebasto]

@KolbyML

Suggesting to convert this PR to a draft while CI fails.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[DrahtBot]

⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[KolbyML]

I no longer have time to work on this so as the bot suggests I am going to close this