Slight improve create wallet dialog #96

Sjors · 2020-09-18T08:24:24Z

Previously only users who needed a second wallet had to use to the create wallet dialog. With the merge of bitcoin/bitcoin#15454 now all new users have to. I don't think it was user-friendly enough for that.

This PR makes a few simple improvements so that new users don't have to think too much:

It's lightly inspired by #77. It would be better if those changes made it into the upcoming release, but this PR is a good start imo.

wallet encryption is no longer checked by default, because such a change in the default needs a separate discussion (fwiw, I suspect it increases the number of users losing access to coins)
watch-only and descriptor wallet stuff is moved to advanced, so new users know they can safely ignore these check boxes
bonus: when you click on "disable private keys" it disables encrypt wallet and checks blank wallet
label changes: see screenshot
tooltip changes: see code diff

Note that a blank wallet name isn't allowed in the dialog; I haven't addressed that.

Update 2020-10-30, dropped the new strings for now:

jonatack · 2020-09-18T08:31:26Z

Concept ACK, seems much better.

I'm probably missing something, but why "blank wallet" instead of "watchonly"?

Sjors · 2020-09-18T08:39:14Z

A blank wallet has no keys at all, but you can add private keys to it. A watch-only wallet has no private keys. A watch-only wallet starts out blank, and then you can't add private keys to it. It's confusing, and probably deserves an even more obscure place in the UI :-)

jonatack · 2020-09-18T08:44:21Z

A blank wallet has no keys at all, but you can add private keys to it. A watch-only wallet has no private keys. A watch-only wallet starts out blank, and then you can't add private keys to it. It's confusing, and probably deserves an even more obscure place in the UI :-)

Thanks. Will test.

GBKS · 2020-09-18T09:23:08Z

Good changes. Could "Encrypt wallet" also be "Protect wallet with a password"? Would it be possible to add links to resources that explain the advanced options to more easily read up on what they do?

Sjors · 2020-09-18T09:42:32Z

@GBKS I think I'll leave that for whoever implements #77

Bosch-0 · 2020-09-18T09:43:09Z

Concept ACK, could you not call 'disable private keys' watch-only wallet? It's both technically correct and I'd assume is a more familiar term to users.

Good changes. Could "Encrypt wallet" also be "Protect wallet with a password"?

Wouldn't Encrypt private keys be more accurate? The wallet isn't being encrypted only the private keys from my understanding - though I think wallet contents a long with meta data like tx history should also be encrypted at some point (again, this is also a familiar process to many users). If this change is made Encrypt wallet or protect wallet with a password is more suitable.

Relevant discussion bitcoin/bitcoin#18085

Sjors · 2020-09-18T10:21:49Z

I updated same labels and tooltips.

harding · 2020-09-18T11:00:41Z

Concept ACK. I like the idea of separating out the confusing and less-often-needed features into an advanced section.

maflcko · 2020-09-20T17:58:36Z

Concept ACK

promag · 2020-09-20T21:19:16Z

src/qt/createwalletdialog.cpp

+
+        // Wallets without private keys start out blank
+        if (checked) {
+            ui->blank_wallet_checkbox->setChecked(true);


Should also disable blank_wallet_checkbox?

Neh, it gets too tedious. It doesn't matter what you do with this checkbox, it's ignored for watch-only.

hebasto

Concept ACK e84e07c, tested on Linux Mint 20 (x86_64, Qt 5.12.8).

master (875e1cc):
this PR (e84e07c):

I'd prefer to see more designers (@Bosch-0, @GBKS) ACKs or comments after the recent update.

src/qt/forms/createwalletdialog.ui

joernroeder · 2020-10-05T22:24:04Z

I am only following the discussion here, therefore I might miss something. First of all, I like the separation into advanced features, but I don't like the idea to disable the encryption by default and would prefer a "fail safe" strategy here.
As users might not know the consequences, add a description explaining them and potential loss of funds next to the password input fields in the next step or – when users check it off, describe the potential risk next to/below the checkbox.

Both decisions have their pro and cons, I would at least explain why encryption was the default in the first place.

Another minor question: Why PascalCase in the placeholder?

GBKS · 2020-10-06T07:47:48Z

I'm wondering if "Manually import seed or keys" would be a more helpful label since that is what the user wants to do (Skipping the seed generation is what allows them to import a seed or keys, but it's not their actual goal)? What do you think?

Otherwise, looks great.

Bosch-0 · 2020-10-07T11:42:55Z

Concept ACK, looks good on Windows 10. I agree with with Christoph on renaming 'Skip seed generation' to 'Manually import seed or keys', it's more action driven.

harding · 2020-10-07T16:20:59Z

@joernroeder

I don't like the idea to disable the encryption by default and would prefer a "fail safe" strategy here.

FYI, no released version of Bitcoin Core has ever created encrypted wallets by default; this PR just preserves that legacy.

As background, there's an open question between experts about whether or not the use of wallet encryption in typical user wallets saves more money than it loses. It saves money if someone gets a hold of just your wallet file (if they get direct access to your computer, they can observe your passphrase and steal your funds any way). It loses money if you forget your passphrase. Some experts believe the number of occasions where a wallet file has fallen into a attacker's hands without that attacker getting direct access to the user's computer is small compared to the large number of occasions where a user has forgotten their passphrase, so it's on average safer not to use encryption.

(I don't hold a strong opinion here myself. I assume that any bitcoins stored in my hot wallet will be stolen someday and prefer leaving my wallet unencrypted so I'm likely to learn about the theft as early as possible.)

I also like @GBKS's suggested label rename to Manually import seed or keys.

laanwj · 2020-10-07T16:52:17Z

Some experts believe the number of occasions where a wallet file has fallen into a attacker's hands without that attacker getting direct access to the user's computer is small compared to the large number of occasions where a user has forgotten their passphrase, so it's on average safer not to use encryption.

If it's anything to go by I've received way more sob stories about people losing their wallet passphrase than about stolen funds, regarding bitcoin core. I'm not sure that's a reliable measure, but because of this I'm partial to not encrypting by default.
In any case the kind of scenario where encryption works is "other people have physical access to my PC but won't use it to install a keylogger/backdoor", not so much remote exploitation. Or cases where the browser can grab a specific named file to upload but not otherwise gain access.

Bosch-0 · 2020-10-08T03:58:48Z

I agree with not encrypting by default. Hot wallets should only be used for small amounts and should not warrant the extra security complexity. An external signer (coming soon to the GUI #4) should be used for larger amounts at a minimum. Though what consists of a larger amount will vary from person to person. The various security levels and trade offs of each wallet type should be communicated to users clearly (Getting there #77).

joernroeder · 2020-10-08T07:34:29Z

Thank you @harding for all the details. It seems like I misinterpreted the first screenshot as the current default which has encryption checked. Also thanks @Bosch-0 for pointing me to #77 which is what I had in mind.

Sjors · 2020-10-08T09:39:05Z

@joernroeder the default for the (only recently introduced) wallet creation dialog was to enable encryption. But the default wallet that Bitcoin Core creates for new users has encryption disabled. Until recently the wallet creation dialog was only used by people creating a second wallet, which presumable is a more experienced subset of users.

I'll keep the Manually import seed or keys. suggestion in mind in case I need to rebase, but prefer to conserve ACKs.

hebasto · 2020-10-15T12:41:22Z

@Sjors

... but prefer to conserve ACKs.

Which one? 😃

Sjors · 2020-10-15T14:45:49Z

Right... rebased and changed the label.

hebasto

ACK ad0874e, tested on Linux Mint 20 (x86_64, Qt 5.12.8).

For the nice commit history mind squashing commits "gui: create wallet: add advanced section" and "gui: rename duplicate label in createwalletdialog.ui"?

Sjors · 2020-10-15T17:54:27Z

src/qt/forms/createwalletdialog.ui

   </property>
   <property name="text">
-    <string>Descriptor Wallet</string>
+    <string>Use descriptors</string>


The word "wallet" seems redundant. Also, you can mix and match, e.g. a watch-only descriptor wallet (not a watch-only wallet descriptor wallet)

Watch-only implies blank (checkbox enforces that), other than that there's no restriction. See also the createwallet RPC documentation, which this is dumb mimic of. These features are almost impossible to use without a deep understanding of the wallet or a tutorial telling you what to do, I don't expect any on screen text to fix that.

The main point of this PR is to make v0.21 slightly more usable than it is now, because we no longer create a default wallet and every new users has to plough through this dialog. I'd rather not fine tune this too much, that's what #77 is for.

jonatack · 2020-10-15T16:34:00Z

src/qt/forms/createwalletdialog.ui

   </property>
   <property name="text">
-    <string>Make Blank Wallet</string>
+    <string>Manually import seed or keys</string>


This change seems confusing, even really misleading (and wasn't in your original proposal), nothing is being imported at this step.. "Blank" or "Skip..." along with the previous tooltip was more clear IMO. Where there is doubt as to the change to make, it's better to not change it.

Anyone using this feature will probably be following a tutorial, so I don't think we should bikeshed this to death. I can see a followup design improvement adding a wizard where you can copy-paste descriptors at this step.

ryanofsky · 2020-11-13T14:53:28Z

I'm not sure what you mean. This is basically the original behaviour where the first wallet is wallet.dat. The UI already handles it.

Right, and it was intentionally disabled in bitcoin/bitcoin#15454 and 78863e2 from bitcoin/bitcoin#15450. The new commit 03ebe1b removes the code which disables it. I don't think the change is a good idea and wrote some reasons why. Would be happy to discuss more, but the point is this change goes beyond tweaking the dialog and shouldn't be part of this PR

Sjors · 2020-11-13T17:37:09Z

bitcoin/bitcoin#15450 introduced the ability to add additional wallets in the GUI, basically an advanced feature. It wasn't designed to be part of the onboarding flow. It makes sense that it didn't allow a blank wallet name, because it would never be used to create the initial wallet.

The PR description of bitcoin/bitcoin#15454 says (emphasis mine):

Instead of automatically creating and loading a default wallet, users should instead explicitly create their wallet or load it on start.

It wasn't clear to me that intention of that PR was to get rid of the unnamed wallet entirely. It seemed more like an oversight to me.

That said, I don't object to ditching the unnamed wallet. But it does create the annoying problem of the user having to pick a name.

I can drop the last commit (or the maintainer can just omit it from the merge) if needed.

ryanofsky · 2020-11-13T18:26:45Z

PR title "Slight improve create wallet dialog" title is currently misleading. Right now this PR is also adding back ability to create a top-level unnamed wallet containing other wallets from the GUI that was removed in #15454 (definitely intentional for me, though I can't speak for other participants).

I don't think commit 03ebe1b is a good idea. I think it is confusing for a wallet to contain other wallets. I think wallets that are unnamed are more likely to get lost and not backed up properly than wallets that have recognizable names. I think if the last commit 03ebe1b is desirable at all, it should be a standalone PR, which should have some rationale stating why it is desirable. It shouldn't be tacked on to a PR doing other cleanup as an extra commit with no rationale or description. Even from discussion in this PR, I haven't seen any justification of the commit, except as workaround to avoid adding a translation string.

It seems fine to just drop the placeholder string if we can't have a translation now and don't want an untranslated string. I think commit 03ebe1b is beyond scope of this PR.

jonatack · 2020-11-13T20:35:19Z

Tested ACK d393708 "gui: create wallet: add advanced section" with the following reservations:

I agree with @ryanofsky about dropping the last commit.
Clicking on the watch-only option does indeed auto-check the blank wallet option but also violates the principle of least surprise and may look to many users like a bug in the code, which may reduce user confidence in the wallet. Perhaps remove this auto-checking, or maybe append (auto-selects "Make Blank Wallet") to the watch-only text to make clear to users what is going on, but the dialog may need to be larger to accomodate that.

For a followup, here's the last list of strings I used:

Encrypt private keys:
Private keys in the wallet will be encrypted with a passphrase of your choice. Addresses, transaction history and notes are not encrypted.

Watch-only
Disable private keys for this wallet. Watch-only wallets have no private keys and cannot have an HD seed or imported private keys.

For now or later, I like these two changes.

Another minor question: Why PascalCase in the placeholder?

Had the same thought. Maybe "My Wallet".

jonatack · 2020-11-13T20:41:22Z

src/qt/forms/createwalletdialog.ui

+    </rect>
+   </property>
+   <property name="styleSheet">
+    <string notr="true">font-weight:bold;</string>


(QT newb question: what is notr?)

Sorry, should have looked it up. Per https://doc.qt.io/qt-5/designer-creating-custom-widgets.html, if the notr optional attribute is true, the value is not meant to be translated.

I just copy-pasted that from another ui file :-)

string is not translated :)

Sjors · 2020-11-14T12:18:00Z

@ryanofsky I still don't understand what you mean with "wallet to contain other wallets". It's just one wallet.

I dropped the last commit. To the degree it wasn't clear whether disallowing the "" wallet was intentional, it is now :-)

I changed "MyWallet" to "Wallet" to avoid CamelCase and at the same avoid spaces in directory names, which tend to trip up badly written backup commands. For future versions we can translate it, but I suggest hinting to the translators to avoid spaces. Unicode characters (e.g. Angličtina) are probably fine, because afaik we have tests for those. But Arab seems to have a space: محفظة نقود

I don't think dropping the placeholder completely, yet not allowing a blank name, is a good idea: users won't know why Create is disabled and they'll probably start selecting random options. (that might still happen, but the placeholder gives at least some hint that picking a name is mandatory)

Of course it's just a placeholder text so the user might type something completely different. I'm still not a fan of forcing users to pick a name, but agree it should be out of scope for this PR.

Clicking on the watch-only option does indeed auto-check the blank wallet option but also violates the principle of least surprise

It's similar to the pre-existing behaviour of clicking on Encrypt wallet. Explaining the behaviour better makes sense, but since I can't change the strings, that would be for a followup (I also don't want to risk whack-a-mole by touching window size, though that's probably safe).

hebasto

re-ACK ac64cec

Two new strings are added after translation freeze:

gui/src/qt/forms/createwalletdialog.ui

Line 42 in ac64cec

<string>Wallet</string>
gui/src/qt/forms/createwalletdialog.ui

Line 90 in ac64cec

<string>Advanced options</string>

I'm ok with them though, as the main goal--to disable wallet encryption by default--could be achieved in 0.21.

@harding

FYI, no released version of Bitcoin Core has ever created encrypted wallets by default; this PR just preserves that legacy.

A screenshot from 0.20.1:

I agree that implementation details could be improved (#96 (comment)) in a followup.

@Sjors
I apologize for the delay in the review.

Rspigler · 2020-11-14T20:14:29Z

Encrypt Wallet is still incorrectly described.

Checking Disable Private Keys checks Make Blank Wallet (and disables Encrypt Wallet). (This is correct).
However, unchecking Make Blank Wallet should uncheck Disable Private Keys (and re-enable for checking Encrypt Wallet). Currently, it does nothing.

Currently, you are left with settings: Disable Private Keys checked, Make Blank Wallet unchecked, and Encrypt Wallet disabled. This seems like a bug when compared to the second sentence in my post.

If we are trying to fit this in 0.21 I guess these can be fixed in another PR

fjahr · 2020-11-16T00:48:05Z

Tested ACK ac64cec

Tested on MacOS 10.15.7. Seems like a great improvement!

ryanofsky

Code review ACK ac64cec. Only changes since last review are tweaking placeholder text and dropping "allow nameless" commit

@ryanofsky I still don't understand what you mean with "wallet to contain other wallets". It's just one wallet.

Sorry, didn't see earlier question. This is just referring to one wallet directory containing another wallet directory, e.g:

wallets/wallet.dat
wallets/db.log
wallets/wallet2/wallet.dat
wallets/wallet2/db.log

instead of

wallets/wallet1/wallet.dat
wallets/wallet1/db.log
wallets/wallet2/wallet.dat
wallets/wallet2/db.log

jonatack · 2020-11-16T11:39:43Z

re-ACK ac64cec, per git diff d393708 ac64cec only change since my last review is improving the placeholder from "MyWallet" to "Wallet" and dropping the last commit. Tested creating a dozen wallets in signet with different combinations of options and then verifying/comparing their characteristics in the console with getwalletinfo. My remaining caveats are (1) the need for less user surprise by either (a) improving the user info or (b) with less auto-(un)selecting as mentioned in #96 (comment) and (2) I prefer the "Encrypt private keys" and "Watch-only" wording and descriptions below over the current ones; hopefully these can be addressed in a follow-up.

Clicking on the watch-only option does indeed auto-check the blank wallet option but also violates the principle of least surprise and may look to many users like a bug in the code, which may reduce user confidence in the wallet. Perhaps remove this auto-checking, or maybe append (auto-selects "Make Blank Wallet") to the watch-only text to make clear to users what is going on, but the dialog may need to be larger to accomodate that.

For a followup, here's the last list of strings I used:

Encrypt private keys:
Private keys in the wallet will be encrypted with a passphrase of your choice. Addresses, transaction history and notes are not encrypted.

Watch-only
Disable private keys for this wallet. Watch-only wallets have no private keys and cannot have an HD seed or imported private keys.

For now or later, I like these two changes.

jonatack · 2020-11-16T11:49:55Z

Sorry, didn't see earlier question. This is just referring to one wallet directory containing another wallet directory, e.g:
wallets/wallet.dat
wallets/db.log
wallets/wallet2/wallet.dat
wallets/wallet2/db.log
instead of
wallets/wallet1/wallet.dat
wallets/wallet1/db.log
wallets/wallet2/wallet.dat
wallets/wallet2/db.log

Agree, I'm seeing the same. And also, in signet the wallets do not even have their own wallets subdirectory.

Sjors · 2020-11-16T15:23:20Z

in signet the wallets do not even have their own wallets subdirectory

That would be very odd, maybe worth a seperate github issue. Did you start with pre-existing /signet directory?

jonatack · 2020-11-16T15:53:43Z

in signet the wallets do not even have their own wallets subdirectory

That would be very odd, maybe worth a seperate github issue. Did you start with pre-existing /signet directory?

Thanks for circling back on that. I tested several different versions of the signet implementation PR before it was merged, but also rm -rf'ed that dir as many times. I guess I should start once again with a fresh signet dir to check.

Sjors · 2020-11-17T12:25:11Z

Thanks for the merge!

I'm leaving the text changes followup up for grabs. Might be worth adding a checkbox for the "avoid reuse" flag too, but it will need some explanation.

ac64cec gui: create wallet: add advanced section (Sjors Provoost) c99d6f6 gui: create wallet: name placeholder (Sjors Provoost) 5bff825 [gui] create wallet: smarter checkbox toggling (Sjors Provoost) Pull request description: Previously only users who needed a second wallet had to use to the create wallet dialog. With the merge of bitcoin#15454 now all new users have to. I don't think it was user-friendly enough for that. <img width="403" alt="Schermafbeelding 2020-09-18 om 09 41 44" src="https://user-images.githubusercontent.com/10217/93574129-52ef9680-f998-11ea-9a6f-31144f66d3bf.png"> This PR makes a few simple improvements so that new users don't have to think too much: <img width="369" alt="Schermafbeelding 2020-10-15 om 16 45 22" src="https://user-images.githubusercontent.com/10217/96145959-0c914700-0f06-11eb-9526-cf447d841d7a.png"> It's lightly inspired by #77. It would be better if those changes made it into the upcoming release, but this PR is a good start imo. * wallet encryption is no longer checked by default, because such a change in the default needs a separate discussion (fwiw, I suspect it increases the number of users losing access to coins) * watch-only and descriptor wallet stuff is moved to advanced, so new users know they can safely ignore these check boxes * bonus: when you click on "disable private keys" it disables encrypt wallet and checks blank wallet * label changes: see screenshot * tooltip changes: see code diff Note that a blank wallet name isn't allowed in the dialog; I haven't addressed that. _Update 2020-10-30_, dropped the new strings for now: <img width="450" alt="Schermafbeelding 2020-10-30 om 11 26 55" src="https://user-images.githubusercontent.com/10217/97694591-1b99fc80-1aa3-11eb-8b85-e19f1ad5add4.png"> ACKs for top commit: fjahr: Tested ACK ac64cec jonatack: re-ACK ac64cec, per `git diff d393708 ac64cec` only change since my last review is improving the placeholder from "MyWallet" to "Wallet" and dropping the last commit. Tested creating a dozen wallets in signet with different combinations of options and then verifying/comparing their characteristics in the console with getwalletinfo. My remaining caveats are (1) the need for less user surprise by either (a) improving the user info or (b) with less auto-(un)selecting as mentioned in bitcoin-core/gui#96 (comment) and (2) I prefer the "Encrypt private keys" and "Watch-only" wording and descriptions below over the current ones; hopefully these can be addressed in a follow-up. hebasto: re-ACK ac64cec ryanofsky: Code review ACK ac64cec. Only changes since last review are tweaking placeholder text and dropping "allow nameless" commit Tree-SHA512: a25f84eb66ee4f99af441d73e33928df9d9cf592177398ef48f0037f5913699e47a162cf1301c83b34501546d43ff4ae12607fd078c5c03b92f573bf7604a9f2

d4feb68 qt: Use layout manager for Create Wallet dialog (Hennadii Stepanov) Pull request description: On master (e75f91e) not using layout manager causes problems with resizing: ![Screenshot from 2021-01-01 13-03-13](https://user-images.githubusercontent.com/32963518/103437728-ce1d4580-4c33-11eb-8915-1e9482775653.png) ![Screenshot from 2021-01-01 13-03-26](https://user-images.githubusercontent.com/32963518/103437730-d6758080-4c33-11eb-9e0f-87d0dd487fcb.png) Also text labels are not resized properly on some window managers (#20777), or if their lengths are changed (after translation). This PR introduces a standard layout manager for the "Create Wallet" dialog that fixes all layout issues (actually, the `createwalletdialog.ui` has been re-written from scratch): ![Screenshot from 2021-01-01 13-10-03](https://user-images.githubusercontent.com/32963518/103437822-d0cc6a80-4c34-11eb-84fd-fcb10a16d9ef.png) ![Screenshot from 2021-01-06 23-50-36](https://user-images.githubusercontent.com/32963518/103823090-0b416780-507a-11eb-89dd-3f48a358e168.png) Additional visual changes: - advanced options are grouped in `QGroupBox` (bitcoin-core/gui#96 (comment)) - enabled the [size grip](https://doc.qt.io/qt-5/qsizegrip.html#details) Fix #20777 ACKs for top commit: jarolrod: ACK d4feb68 Sjors: re-tACK d4feb68 promag: Tested ACK d4feb68 on macos. Tree-SHA512: 4c055962e49f88624900b880b33a866976d224628784593428b712d2e94563d77ddefddea3397134d20e72f738a8cf9aa885c1272fd9ffc90213c104435fb9f4

d4feb68 qt: Use layout manager for Create Wallet dialog (Hennadii Stepanov) Pull request description: On master (e75f91e) not using layout manager causes problems with resizing: ![Screenshot from 2021-01-01 13-03-13](https://user-images.githubusercontent.com/32963518/103437728-ce1d4580-4c33-11eb-8915-1e9482775653.png) ![Screenshot from 2021-01-01 13-03-26](https://user-images.githubusercontent.com/32963518/103437730-d6758080-4c33-11eb-9e0f-87d0dd487fcb.png) Also text labels are not resized properly on some window managers (bitcoin#20777), or if their lengths are changed (after translation). This PR introduces a standard layout manager for the "Create Wallet" dialog that fixes all layout issues (actually, the `createwalletdialog.ui` has been re-written from scratch): ![Screenshot from 2021-01-01 13-10-03](https://user-images.githubusercontent.com/32963518/103437822-d0cc6a80-4c34-11eb-84fd-fcb10a16d9ef.png) ![Screenshot from 2021-01-06 23-50-36](https://user-images.githubusercontent.com/32963518/103823090-0b416780-507a-11eb-89dd-3f48a358e168.png) Additional visual changes: - advanced options are grouped in `QGroupBox` (bitcoin-core/gui#96 (comment)) - enabled the [size grip](https://doc.qt.io/qt-5/qsizegrip.html#details) Fix bitcoin#20777 ACKs for top commit: jarolrod: ACK d4feb68 Sjors: re-tACK d4feb68 promag: Tested ACK d4feb68 on macos. Tree-SHA512: 4c055962e49f88624900b880b33a866976d224628784593428b712d2e94563d77ddefddea3397134d20e72f738a8cf9aa885c1272fd9ffc90213c104435fb9f4

This was referenced Sep 18, 2020

Remove the automatic creation and loading of the default wallet bitcoin/bitcoin#15454

Merged

[Design] New 'Create Wallet' user flow. #77

Open

Sjors force-pushed the 2020/09/create_wallet branch 2 times, most recently from b0e58cd to e84e07c Compare September 18, 2020 10:21

promag reviewed Sep 20, 2020

View reviewed changes

hebasto reviewed Oct 5, 2020

View reviewed changes

src/qt/forms/createwalletdialog.ui Outdated Show resolved Hide resolved

Bosch-0 mentioned this pull request Oct 8, 2020

Who is the GUI being designed for? -Continued Discussion- #45

Closed

Sjors force-pushed the 2020/09/create_wallet branch 2 times, most recently from 560236a to ad0874e Compare October 15, 2020 14:45

hebasto requested changes Oct 15, 2020

View reviewed changes

jonatack reviewed Oct 15, 2020

View reviewed changes

jonatack reviewed Nov 13, 2020

View reviewed changes

Sjors added 2 commits November 14, 2020 13:07

gui: create wallet: name placeholder

c99d6f6

gui: create wallet: add advanced section

ac64cec

Sjors force-pushed the 2020/09/create_wallet branch from 03ebe1b to ac64cec Compare November 14, 2020 12:16

hebasto approved these changes Nov 14, 2020

View reviewed changes

ryanofsky approved these changes Nov 16, 2020

View reviewed changes

maflcko merged commit e7986c5 into bitcoin-core:master Nov 17, 2020

Sjors deleted the 2020/09/create_wallet branch November 17, 2020 12:25

apoelstra added a commit to apoelstra/elements that referenced this pull request Dec 3, 2020

Merge e7986c5 into merged_master (Bitcoin PR bitcoin-core/gui#96)

aeb428e

Rspigler mentioned this pull request Dec 14, 2020

Issues with new create wallet dialogue #151

Open

Sjors mentioned this pull request Dec 30, 2020

v0.21.0 testing bitcoin/bitcoin#20555

Closed

hebasto mentioned this pull request Jan 1, 2021

Use layout manager for Create Wallet dialog #171

Merged

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Mar 23, 2021

Merge e7986c5 into merged_master (Bitcoin PR bitcoin-core/gui#96)

50dafec

Rspigler mentioned this pull request Jul 28, 2021

Document about wallet backup and restoration bitcoin/bitcoin#22523

Merged

bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022

Slight improve create wallet dialog #96

Slight improve create wallet dialog #96

Conversation

Sjors commented Sep 18, 2020 • edited Loading

jonatack commented Sep 18, 2020

Sjors commented Sep 18, 2020 • edited Loading

jonatack commented Sep 18, 2020

GBKS commented Sep 18, 2020

Sjors commented Sep 18, 2020

Bosch-0 commented Sep 18, 2020

Sjors commented Sep 18, 2020

harding commented Sep 18, 2020

maflcko commented Sep 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hebasto left a comment

Choose a reason for hiding this comment

joernroeder commented Oct 5, 2020

GBKS commented Oct 6, 2020

Bosch-0 commented Oct 7, 2020

harding commented Oct 7, 2020

laanwj commented Oct 7, 2020 • edited Loading

Bosch-0 commented Oct 8, 2020

joernroeder commented Oct 8, 2020

Sjors commented Oct 8, 2020 • edited Loading

hebasto commented Oct 15, 2020

Sjors commented Oct 15, 2020

hebasto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sjors Oct 15, 2020 • edited Loading

Choose a reason for hiding this comment

jonatack Oct 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanofsky commented Nov 13, 2020 • edited Loading

Sjors commented Nov 13, 2020 • edited Loading

ryanofsky commented Nov 13, 2020

jonatack commented Nov 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sjors commented Nov 14, 2020 • edited Loading

hebasto left a comment

Choose a reason for hiding this comment

Rspigler commented Nov 14, 2020

fjahr commented Nov 16, 2020

ryanofsky left a comment • edited Loading

Choose a reason for hiding this comment

jonatack commented Nov 16, 2020 • edited Loading

jonatack commented Nov 16, 2020

Sjors commented Nov 16, 2020

jonatack commented Nov 16, 2020

Sjors commented Nov 17, 2020 • edited Loading

Sjors commented Sep 18, 2020 •

edited

Loading

Sjors commented Sep 18, 2020 •

edited

Loading

laanwj commented Oct 7, 2020 •

edited

Loading

Sjors commented Oct 8, 2020 •

edited

Loading

Sjors Oct 15, 2020 •

edited

Loading

jonatack Oct 15, 2020 •

edited

Loading

ryanofsky commented Nov 13, 2020 •

edited

Loading

Sjors commented Nov 13, 2020 •

edited

Loading

jonatack commented Nov 13, 2020 •

edited

Loading

Sjors commented Nov 14, 2020 •

edited

Loading

ryanofsky left a comment •

edited

Loading

jonatack commented Nov 16, 2020 •

edited

Loading

Sjors commented Nov 17, 2020 •

edited

Loading