Increase maximum read-only mmap()s used from 1000 to 4096 on 64-bit systems #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 64 bit systems. By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back to using file desciptors. The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files seems arbitarily small. Increase this value to another arbitrarily small value, 4096.
|
LGTM. ACK |
|
utACK |
|
@laanwj Is this for 0.17.0? If so, we should merge it here to give some time for testing. |
|
utACK 4874cb8 |
laanwj
added a commit
that referenced
this pull request
Aug 9, 2018
…on 64-bit systems 4874cb8 Increase maximum number of read-only mmap()s used from 1000 to 4096 on 64 bit systems. (Clem Taylor) Pull request description: By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back to using file desciptors. The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files seems arbitarily small. Increase this value to another arbitrarily small value, 4096. Tree-SHA512: 42d0978f229603aa882ac47a43ec455be0e27c9c3e4d7e36f7e6b49bab6da7c1bd0d3ffbaca22dfda2a5722fa533d1ce7439e9f99fdedb64df0c4442bbb6a93c
1 task
|
Has this been upstreamed yet? |
laanwj
added a commit
that referenced
this pull request
Nov 6, 2019
…n 64-bit systems This code moved, re-apply it elsewhere. See #19. Original change by Clem Taylor.
laanwj
added a commit
that referenced
this pull request
Nov 6, 2019
…n 64-bit systems This code moved, re-apply it elsewhere. See #19. Original change by Clem Taylor.
laanwj
added a commit
that referenced
this pull request
Nov 6, 2019
…n 64-bit systems This code moved, re-apply it elsewhere. See #19. Original change by Clem Taylor.
laanwj
pushed a commit
that referenced
this pull request
Nov 7, 2019
…ystems By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back to using file desciptors. The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files seems arbitarily small. Increase this value to another arbitrarily small value, 4096. See #19. Original change by Clem Taylor. Ported to LevelDB 1.22 by Wladimir J. van der Laan.
laanwj
pushed a commit
that referenced
this pull request
Nov 7, 2019
…ystems By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back to using file desciptors. The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files seems arbitarily small. Increase this value to another arbitrarily small value, 4096. See #19. Original change by Clem Taylor. Ported to LevelDB 1.22 by Wladimir J. van der Laan.
richmills3
pushed a commit
to nchain-research/leveldb
that referenced
this pull request
Mar 12, 2021
…ystems By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back to using file desciptors. The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files seems arbitarily small. Increase this value to another arbitrarily small value, 4096. See bitcoin-core#19. Original change by Clem Taylor. Ported to LevelDB 1.22 by Wladimir J. van der Laan.
richmills3
pushed a commit
to nchain-research/leveldb
that referenced
this pull request
Mar 17, 2021
…ystems By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back to using file desciptors. The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files seems arbitarily small. Increase this value to another arbitrarily small value, 4096. See bitcoin-core#19. Original change by Clem Taylor. Ported to LevelDB 1.22 by Wladimir J. van der Laan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default LevelDB will only mmap() up to 1000 ldb files for reading and then fall back
to using file desciptors.
The typical linux system has a 'vm.max_map_count = 65530', so mapping only 1000 files
seems arbitarily small. Increase this value to another arbitrarily small value, 4096.