-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge #1412: ci: Switch macOS from Ventura to Monterey and add Valgrind
c223d7e ci: Switch macOS from Ventura to Monterey and add Valgrind (Hennadii Stepanov) Pull request description: This PR switches the macOS native job from Ventura to Monterey, which allows to support Valgrind. Both runners--`macos-12` and `macos-13`--have the same clang compilers installed: - https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md - https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md But Valgrind works fine on macOS Monterey, but not on Ventura. See: #1392 (comment). The Homebrew's Valgrind package is cached once it has been built (as it was before #1152). Therefore, the `actions/cache@*` action is needed to be added to the list of the allowed actions. #1412 (comment): > By the way, this solves #1151. ACKs for top commit: real-or-random: ACK c223d7e I tested that a cttest failure makes CI fail: https://github.com/real-or-random/secp256k1/actions/runs/6010365844 Tree-SHA512: 5e72d89fd4d82acbda8adeda7106db0dad85162cca03abe8eae9a40393997ba36a84ad7b12c4b32aec5e9230f275738ef12169994cd530952e2b0b963449b231
- Loading branch information
Showing
2 changed files
with
45 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: "Install Valgrind" | ||
description: "Install Homebrew's Valgrind package and cache it." | ||
runs: | ||
using: "composite" | ||
steps: | ||
- run: | | ||
brew tap LouisBrunner/valgrind | ||
brew fetch --HEAD LouisBrunner/valgrind/valgrind | ||
echo "CI_HOMEBREW_CELLAR_VALGRIND=$(brew --cellar valgrind)" >> "$GITHUB_ENV" | ||
shell: bash | ||
- run: | | ||
sw_vers > valgrind_fingerprint | ||
brew --version >> valgrind_fingerprint | ||
git -C "$(brew --cache)/valgrind--git" rev-parse HEAD >> valgrind_fingerprint | ||
cat valgrind_fingerprint | ||
shell: bash | ||
- uses: actions/cache@v3 | ||
id: cache | ||
with: | ||
path: ${{ env.CI_HOMEBREW_CELLAR_VALGRIND }} | ||
key: ${{ github.job }}-valgrind-${{ hashFiles('valgrind_fingerprint') }} | ||
|
||
- if: steps.cache.outputs.cache-hit != 'true' | ||
run: | | ||
brew install --HEAD LouisBrunner/valgrind/valgrind | ||
shell: bash | ||
|
||
- if: steps.cache.outputs.cache-hit == 'true' | ||
run: | | ||
brew link valgrind | ||
shell: bash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters