Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some misspellings #1634

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix some misspellings #1634

merged 1 commit into from
Nov 5, 2024

Conversation

niooss-ledger
Copy link
Contributor

Hello,

Some files contained English misspellings or math issues (lamba instead of lambda), mainly in comments. Fixing them helps readability.

By the way, the misspellings found in the Wycheproof test vector file were also reported upstream: C2SP/wycheproof#124

@real-or-random
Copy link
Contributor

Thanks! Concept ACK, obviously.

By the way, the misspellings found in the Wycheproof test vector file were also reported upstream: C2SP/wycheproof#124

Good, that's probably the right path. And then I think it will be good then not to touch these files here. If you ask me, avoiding conflicts with the upstream is more important than fixing these typos. Could you modify the commit?

@niooss-ledger
Fix some misspellings
3970545 
Some files contained English misspellings or math issues (`lamba`
instead of `lambda`).
@niooss-ledger
Copy link
Contributor Author

I think it will be good then not to touch these files here. If you ask me, avoiding conflicts with the upstream is more important than fixing these typos. Could you modify the commit?

Ok, this works for me. I removed the changes related to Wycheproof test vectors.

real-or-random
real-or-random approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3970545

@real-or-random real-or-random merged commit 8deef00 into bitcoin-core:master Nov 5, 2024
111 of 116 checks passed
@niooss-ledger niooss-ledger deleted the fix-some-misspellings branch November 5, 2024 20:13
vmta added a commit to umkoin/umkoin that referenced this pull request Nov 6, 2024
@vmta
Squashed 'src/secp256k1/' changes from 1464f15c8..8deef00b3
b5ae194 
8deef00b3 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450e Fix some misspellings
ec329c250 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f59 release cleanup: bump version after 0.6.0
0cdc758a5 Merge bitcoin-core/secp256k1#1631: release: prepare for 0.6.0
39d5dfd54 release: prepare for 0.6.0
df2eceb27 build: add ellswift.md and musig.md to release tarball
a306bb7e9 tools: fix check-abi.sh after cmake out locations were changed
145868a84 Do not export `secp256k1_musig_nonce_gen_internal`
b161bffb8 Merge bitcoin-core/secp256k1#1579: Clear sensitive memory without getting optimized out (revival of #636)
a38d879a1 Merge bitcoin-core/secp256k1#1628: Name public API structs
7d48f5ed0 Merge bitcoin-core/secp256k1#1581: test, ci: Lower default iteration count to 16
694342fdb Name public API structs
0f73caf7c test, ci: Lower default iteration count to 16
9a8db52f4 Merge bitcoin-core/secp256k1#1582: cmake, test: Add `secp256k1_` prefix to test names
765ef5333 Clear _gej instances after point multiplication to avoid potential leaks
349e6ab91 Introduce separate _clear functions for hash module
99cc9fd6d Don't rely on memset to set signed integers to 0
97c57f42b Implement various _clear() functions with secp256k1_memclear()
9bb368d14 Use secp256k1_memclear() to clear stack memory instead of memset()
e3497bbf0 Separate between clearing memory and setting to zero in tests
d79a6ccd4 Separate secp256k1_fe_set_int( . , 0 ) from secp256k1_fe_clear()
1c0812622 Add secp256k1_memclear() for clearing secret data
e7d384488 Don't clear secrets in pippenger implementation
87384f5c0 cmake, test: Add `secp256k1_` prefix to test names

git-subtree-dir: src/secp256k1
git-subtree-split: 8deef00b33ca81202aca80fe0bcd9730f084fbd2
vmta added a commit to umkoin/umkoin that referenced this pull request Nov 6, 2024
@vmta
Squashed 'src/secp256k1/' changes from 1464f15c8..8deef00b3
8999068 
8deef00b3 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450e Fix some misspellings
ec329c250 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f59 release cleanup: bump version after 0.6.0
0cdc758a5 Merge bitcoin-core/secp256k1#1631: release: prepare for 0.6.0
39d5dfd54 release: prepare for 0.6.0
df2eceb27 build: add ellswift.md and musig.md to release tarball
a306bb7e9 tools: fix check-abi.sh after cmake out locations were changed
145868a84 Do not export `secp256k1_musig_nonce_gen_internal`
b161bffb8 Merge bitcoin-core/secp256k1#1579: Clear sensitive memory without getting optimized out (revival of #636)
a38d879a1 Merge bitcoin-core/secp256k1#1628: Name public API structs
7d48f5ed0 Merge bitcoin-core/secp256k1#1581: test, ci: Lower default iteration count to 16
694342fdb Name public API structs
0f73caf7c test, ci: Lower default iteration count to 16
9a8db52f4 Merge bitcoin-core/secp256k1#1582: cmake, test: Add `secp256k1_` prefix to test names
765ef5333 Clear _gej instances after point multiplication to avoid potential leaks
349e6ab91 Introduce separate _clear functions for hash module
99cc9fd6d Don't rely on memset to set signed integers to 0
97c57f42b Implement various _clear() functions with secp256k1_memclear()
9bb368d14 Use secp256k1_memclear() to clear stack memory instead of memset()
e3497bbf0 Separate between clearing memory and setting to zero in tests
d79a6ccd4 Separate secp256k1_fe_set_int( . , 0 ) from secp256k1_fe_clear()
1c0812622 Add secp256k1_memclear() for clearing secret data
e7d384488 Don't clear secrets in pippenger implementation
87384f5c0 cmake, test: Add `secp256k1_` prefix to test names

git-subtree-dir: src/secp256k1
git-subtree-split: 8deef00b33ca81202aca80fe0bcd9730f084fbd2
Eunovo added a commit to Eunovo/bitcoin that referenced this pull request Nov 7, 2024
@Eunovo
Squashed 'src/secp256k1/' changes from 0cdc758a56..7054b5ebb9
3686f1e 
7054b5ebb9 Clear warnings
c94ed8bbb8 WIP: Silent merge conflicts
4258da6b98 batch: Generate graphs for batch verification speed up
d19d6e7b48 batch, extrakeys: Add benchmark for batch verify and `tweak_add_check`
cd6eed652a batch: Add tests for `batch_add_*` APIs
990dc9f09c batch,ecmult: Add tests for core batch APIs and `strauss_batch` refactor
3740b6b960 batch: Add API usage example
b5765680d1 batch: Add `batch_add_*` APIs
fbefddd908 batch, ecmult: Add `batch_verify` API and refactor `strauss_batch`
6dfd31dea4 batch: Add `create` and `destroy` APIs
1455f0999f batch: Initialize an experimental batch module
8deef00b33 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450eb Fix some misspellings
ec329c2501 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f594 release cleanup: bump version after 0.6.0

git-subtree-dir: src/secp256k1
git-subtree-split: 7054b5ebb937572f4574692051005cb2e9613ffb
vmta added a commit to umkoin/umkoin that referenced this pull request Nov 21, 2024
@vmta
Squashed 'src/secp256k1/' changes from 3fdf146ba..8deef00b3
f40affb 
8deef00b3 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450e Fix some misspellings
ec329c250 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f59 release cleanup: bump version after 0.6.0
0cdc758a5 Merge bitcoin-core/secp256k1#1631: release: prepare for 0.6.0
39d5dfd54 release: prepare for 0.6.0
df2eceb27 build: add ellswift.md and musig.md to release tarball
a306bb7e9 tools: fix check-abi.sh after cmake out locations were changed
145868a84 Do not export `secp256k1_musig_nonce_gen_internal`
b161bffb8 Merge bitcoin-core/secp256k1#1579: Clear sensitive memory without getting optimized out (revival of #636)
a38d879a1 Merge bitcoin-core/secp256k1#1628: Name public API structs
7d48f5ed0 Merge bitcoin-core/secp256k1#1581: test, ci: Lower default iteration count to 16
694342fdb Name public API structs
0f73caf7c test, ci: Lower default iteration count to 16
9a8db52f4 Merge bitcoin-core/secp256k1#1582: cmake, test: Add `secp256k1_` prefix to test names
765ef5333 Clear _gej instances after point multiplication to avoid potential leaks
349e6ab91 Introduce separate _clear functions for hash module
99cc9fd6d Don't rely on memset to set signed integers to 0
97c57f42b Implement various _clear() functions with secp256k1_memclear()
9bb368d14 Use secp256k1_memclear() to clear stack memory instead of memset()
e3497bbf0 Separate between clearing memory and setting to zero in tests
d79a6ccd4 Separate secp256k1_fe_set_int( . , 0 ) from secp256k1_fe_clear()
1c0812622 Add secp256k1_memclear() for clearing secret data
1464f15c8 Merge bitcoin-core/secp256k1#1625: util: Remove unused (u)int64_t formatting macros
980c08df8 util: Remove unused (u)int64_t formatting macros
9b7c59cbb Merge bitcoin-core/secp256k1#1624: ci: Update macOS image
096e3e23f ci: Update macOS image
e7d384488 Don't clear secrets in pippenger implementation
68b55209f Merge bitcoin-core/secp256k1#1619: musig: ctimetests: fix _declassify range for generated nonce points
f0868a9b3 Merge bitcoin-core/secp256k1#1595: build: 45839th attempt to fix symbol visibility on Windows
1fae76f50 Merge bitcoin-core/secp256k1#1620: Remove unused scratch space from API
8be3839fb Remove unused scratch space from API
57eda3ba3 musig: ctimetests: fix _declassify range for generated nonce points
87384f5c0 cmake, test: Add `secp256k1_` prefix to test names
e59158b6e Merge bitcoin-core/secp256k1#1553: cmake: Set top-level target output locations
18f9b967c Merge bitcoin-core/secp256k1#1616: examples: do not retry generating seckey randomness in musig
5bab8f6d3 examples: make key generation doc consistent
e8908221a examples: do not retry generating seckey randomness in musig
70b6be183 extrakeys: improve doc of keypair_create (don't suggest retry)
01b589338 Merge bitcoin-core/secp256k1#1599: #1570 improve examples: remove key generation loop
cd4f84f3b Improve examples/documentation: remove key generation loops
a88aa9350 Merge bitcoin-core/secp256k1#1603: f can never equal -m
3660fe5e2 Merge bitcoin-core/secp256k1#1479: Add module "musig" that implements MuSig2 multi-signatures (BIP 327)
168c92011 build: allow enabling the musig module in cmake
f411841a4 Add module "musig" that implements MuSig2 multi-signatures (BIP 327)
0be79660f util: add constant-time is_zero_array function
c8fbdb1b9 group: add ge_to_bytes_ext and ge_from_bytes_ext
ef7ff0340 f can never equal -m
c232486d8 Revert "cmake: Set `ENVIRONMENT` property for examples on Windows"
26e4a7c21 cmake: Set top-level target output locations
4c57c7a5a Merge bitcoin-core/secp256k1#1554: cmake: Clean up testing code
447334cb0 include: Avoid visibility("default") on Windows
472faaa8e Merge bitcoin-core/secp256k1#1604: doc: fix typos in `secp256k1_ecdsa_{recoverable_,}signature` API description
292310fbb doc: fix typos in `secp256k1_ecdsa_{recoverable_,}signature` API description
2f2ccc469 Merge bitcoin-core/secp256k1#1600: cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
421ed1b46 cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
85e224dd9 group: add ge_to_bytes and ge_from_bytes
198885507 Merge bitcoin-core/secp256k1#1586: fix: remove duplicate 'the' from header file comment
b30761440 Merge bitcoin-core/secp256k1#1583: ci: Bump GCC_SNAPSHOT_MAJOR to 15
fa67b6752 refactor: Use array initialization for unterminated strings
9b0f37bff fix: remove duplicate 'the' from header file comment
e34b47673 ci: Bump GCC_SNAPSHOT_MAJOR to 15
7c987ec89 cmake: Call `enable_testing()` unconditionally
6aa576515 cmake: Delete `CTest` module

git-subtree-dir: src/secp256k1
git-subtree-split: 8deef00b33ca81202aca80fe0bcd9730f084fbd2
vmta added a commit to umkoin/umkoin that referenced this pull request Nov 22, 2024
@vmta
Squashed 'src/secp256k1/' changes from 3fdf146ba..8deef00b3
cc8d145 
8deef00b3 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450e Fix some misspellings
ec329c250 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f59 release cleanup: bump version after 0.6.0
0cdc758a5 Merge bitcoin-core/secp256k1#1631: release: prepare for 0.6.0
39d5dfd54 release: prepare for 0.6.0
df2eceb27 build: add ellswift.md and musig.md to release tarball
a306bb7e9 tools: fix check-abi.sh after cmake out locations were changed
145868a84 Do not export `secp256k1_musig_nonce_gen_internal`
b161bffb8 Merge bitcoin-core/secp256k1#1579: Clear sensitive memory without getting optimized out (revival of #636)
a38d879a1 Merge bitcoin-core/secp256k1#1628: Name public API structs
7d48f5ed0 Merge bitcoin-core/secp256k1#1581: test, ci: Lower default iteration count to 16
694342fdb Name public API structs
0f73caf7c test, ci: Lower default iteration count to 16
9a8db52f4 Merge bitcoin-core/secp256k1#1582: cmake, test: Add `secp256k1_` prefix to test names
765ef5333 Clear _gej instances after point multiplication to avoid potential leaks
349e6ab91 Introduce separate _clear functions for hash module
99cc9fd6d Don't rely on memset to set signed integers to 0
97c57f42b Implement various _clear() functions with secp256k1_memclear()
9bb368d14 Use secp256k1_memclear() to clear stack memory instead of memset()
e3497bbf0 Separate between clearing memory and setting to zero in tests
d79a6ccd4 Separate secp256k1_fe_set_int( . , 0 ) from secp256k1_fe_clear()
1c0812622 Add secp256k1_memclear() for clearing secret data
1464f15c8 Merge bitcoin-core/secp256k1#1625: util: Remove unused (u)int64_t formatting macros
980c08df8 util: Remove unused (u)int64_t formatting macros
9b7c59cbb Merge bitcoin-core/secp256k1#1624: ci: Update macOS image
096e3e23f ci: Update macOS image
e7d384488 Don't clear secrets in pippenger implementation
68b55209f Merge bitcoin-core/secp256k1#1619: musig: ctimetests: fix _declassify range for generated nonce points
f0868a9b3 Merge bitcoin-core/secp256k1#1595: build: 45839th attempt to fix symbol visibility on Windows
1fae76f50 Merge bitcoin-core/secp256k1#1620: Remove unused scratch space from API
8be3839fb Remove unused scratch space from API
57eda3ba3 musig: ctimetests: fix _declassify range for generated nonce points
87384f5c0 cmake, test: Add `secp256k1_` prefix to test names
e59158b6e Merge bitcoin-core/secp256k1#1553: cmake: Set top-level target output locations
18f9b967c Merge bitcoin-core/secp256k1#1616: examples: do not retry generating seckey randomness in musig
5bab8f6d3 examples: make key generation doc consistent
e8908221a examples: do not retry generating seckey randomness in musig
70b6be183 extrakeys: improve doc of keypair_create (don't suggest retry)
01b589338 Merge bitcoin-core/secp256k1#1599: #1570 improve examples: remove key generation loop
cd4f84f3b Improve examples/documentation: remove key generation loops
a88aa9350 Merge bitcoin-core/secp256k1#1603: f can never equal -m
3660fe5e2 Merge bitcoin-core/secp256k1#1479: Add module "musig" that implements MuSig2 multi-signatures (BIP 327)
168c92011 build: allow enabling the musig module in cmake
f411841a4 Add module "musig" that implements MuSig2 multi-signatures (BIP 327)
0be79660f util: add constant-time is_zero_array function
c8fbdb1b9 group: add ge_to_bytes_ext and ge_from_bytes_ext
ef7ff0340 f can never equal -m
c232486d8 Revert "cmake: Set `ENVIRONMENT` property for examples on Windows"
26e4a7c21 cmake: Set top-level target output locations
4c57c7a5a Merge bitcoin-core/secp256k1#1554: cmake: Clean up testing code
447334cb0 include: Avoid visibility("default") on Windows
472faaa8e Merge bitcoin-core/secp256k1#1604: doc: fix typos in `secp256k1_ecdsa_{recoverable_,}signature` API description
292310fbb doc: fix typos in `secp256k1_ecdsa_{recoverable_,}signature` API description
2f2ccc469 Merge bitcoin-core/secp256k1#1600: cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
421ed1b46 cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
85e224dd9 group: add ge_to_bytes and ge_from_bytes
198885507 Merge bitcoin-core/secp256k1#1586: fix: remove duplicate 'the' from header file comment
b30761440 Merge bitcoin-core/secp256k1#1583: ci: Bump GCC_SNAPSHOT_MAJOR to 15
fa67b6752 refactor: Use array initialization for unterminated strings
9b0f37bff fix: remove duplicate 'the' from header file comment
e34b47673 ci: Bump GCC_SNAPSHOT_MAJOR to 15
7c987ec89 cmake: Call `enable_testing()` unconditionally
6aa576515 cmake: Delete `CTest` module

git-subtree-dir: src/secp256k1
git-subtree-split: 8deef00b33ca81202aca80fe0bcd9730f084fbd2
fjahr added a commit to fjahr/bitcoin that referenced this pull request Dec 5, 2024
@fjahr
Squashed 'src/secp256k1/' changes from 0cdc758a56..e440c4fe45
f90c454 
e440c4fe45 build: Add build option for batch module
7c6b9df9ec SQUASH ME: Fix silent merge conflicts
4a0ea6104d batch: Generate graphs for batch verification speed up
a804f05738 batch, extrakeys: Add benchmark for batch verify and `tweak_add_check`
2fa3654b1e batch: Add tests for `batch_add_*` APIs
2167f490c5 batch,ecmult: Add tests for core batch APIs and `strauss_batch` refactor
453a42c22f batch: Add API usage example
564b573451 batch: Add `batch_add_*` APIs
c6577399a0 batch, ecmult: Add `batch_verify` API and refactor `strauss_batch`
bb04d14af5 batch: Add `create` and `destroy` APIs
e28dd3a120 batch: Initialize an experimental batch module
8deef00b33 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450eb Fix some misspellings
ec329c2501 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f594 release cleanup: bump version after 0.6.0

git-subtree-dir: src/secp256k1
git-subtree-split: e440c4fe45b82dba2fb39889c1b5244574ae4bd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@real-or-random real-or-random real-or-random approved these changes

Assignees
No one assigned
Labels
refactor/smell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niooss-ledger @real-or-random