Make argument of fe_normalizes_to_zero{_var} const #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
approved these changes
Mar 12, 2021
|
As the method comments say, it can optionally normalize the value. I believe this had something to do with one of the field implementations at the time (openssl, gmp??) not really having a good option with a const argument. Don't recall. Presumably it is a redundant consideration now. |
|
@peterdettman Ha, good point. At least the comments should be updated. |
sipa
force-pushed
the
202103_const_norm_to_zero
branch
from
147494c
to
23c3fb6
Compare
|
Updated the function descriptions. |
real-or-random
approved these changes
Mar 16, 2021
jonasnick
reviewed
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions do not modify their argument.