Adds debug arg to the CLI #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the JoinSet management to have a single global sets of tasks
Total time can be set via cmd using `--total-time`. If no time is provided, the simulation is run forever
Debug logs can be turned in using `--debug`. Also fixes pending logs
carlaKC
approved these changes
Aug 21, 2023
| @@ -233,6 +233,7 @@ impl Simulation { | |||
| self.activity.len(), | |||
| self.nodes.len() | |||
| ); | |||
| let mut tasks = JoinSet::new(); | |||
| @@ -16,19 +16,35 @@ struct Cli { | |||
| config: PathBuf, | |||
| #[clap(long, short)] | |||
| total_time: Option<u32>, | |||
| #[clap(long, short)] | |||
| debug: bool, | |||
There was a problem hiding this comment.
Bool config option vs passing in a string that allows enabling other values like trace?
okjodom
reviewed
Aug 24, 2023
| } | ||
|
|
||
| #[tokio::main] | ||
| async fn main() -> anyhow::Result<()> { | ||
| let cli = Cli::parse(); |
There was a problem hiding this comment.
would we also want to read in RUST_LOG environment at this point?
okjodom
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug logs can be turned in using
--debug.Also fixes pending logs.