Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CLN #74

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Adds CLN #74

merged 3 commits into from
Aug 23, 2023

Conversation

sr-gi
Copy link
Member

@sr-gi sr-gi commented Aug 23, 2023

Currently we only accept one type of node, LndNode.

This generalizes the type of connection so other nodes can be added and adds CLN as an additional node type.

track_payment is currently missing though

@sr-gi
Copy link
Member Author

sr-gi commented Aug 23, 2023

@okjodom you should be able to build the CLN client based on this.

`track_payment` is missing
@sr-gi sr-gi changed the title Sets the basic structure for NodeConnections so other lightning nodes can be parsed from the config file Adds CLN Aug 23, 2023
@sr-gi sr-gi force-pushed the define-node-types branch 2 times, most recently from 68d3ec6 to 3880b1e Compare August 23, 2023 15:00
@sr-gi sr-gi requested review from carlaKC and okjodom and removed request for carlaKC August 23, 2023 15:05
@sr-gi
Copy link
Member Author

sr-gi commented Aug 23, 2023

It is worth noting that we've replaced get_node_info for get_node_features. For LND, we are currently only returning NodeFeatures signaling wether keysend is enabled or not. This is a bit nasty, so we should add a method to build NodeFeatures to consider every single signaled feature

@okjodom
Copy link
Collaborator

okjodom commented Aug 23, 2023

tACK

@okjodom okjodom merged commit df54576 into bitcoin-dev-project:main Aug 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants