This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
feat(spv-642): return ArcError to prevent infinite broadcasting of invalid transactions #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Tests💚 Manual testing by @wregulski resulted in success. |
Nazarii-4chain
previously approved these changes
Apr 19, 2024
chris-4chain
previously approved these changes
Apr 19, 2024
dorzepowski
suggested changes
May 13, 2024
wregulski
dismissed stale reviews from chris-4chain and Nazarii-4chain
via
3b9c5fd
Nazarii-4chain
approved these changes
May 14, 2024
dorzepowski
approved these changes
May 15, 2024
|
I marked is as tested manually, it was tested by @pawellewandowski98 along with SPV-Wallet |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist