Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-245): delete ExecuteSimplifiedPaymentVerification from PaymailServieProvider #20

Merged
merged 1 commit into from
Sep 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions examples/server/run_server/demo_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,3 @@ func (d *demoServiceProvider) RecordTransaction(ctx context.Context,
// Record the tx into your datastore layer
return DemoRecordTransaction(ctx, p2pTx)
}

// ExecuteSimplifiedPaymentVerification is a demo implementation of this interface
func (d *demoServiceProvider) ExecuteSimplifiedPaymentVerification(ctx context.Context,
beedData *paymail.DecodedBEEF) error {

return nil
}
5 changes: 0 additions & 5 deletions server/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,4 @@ type PaymailServiceProvider interface {
p2pTx *paymail.P2PTransaction,
metaData *RequestMetadata,
) (*paymail.P2PTransactionPayload, error)

ExecuteSimplifiedPaymentVerification(
ctx context.Context,
beedData *paymail.DecodedBEEF,
) error
}
7 changes: 0 additions & 7 deletions server/mock_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,3 @@ func (m *mockServiceProvider) RecordTransaction(_ context.Context,
// Record the tx into your datastore layer
return nil, nil
}

// ExecuteSimplifiedPaymentVerification is a mock implementation of this interface
func (m *mockServiceProvider) ExecuteSimplifiedPaymentVerification(ctx context.Context,
beedData *paymail.DecodedBEEF) error {

return nil
}
2 changes: 1 addition & 1 deletion server/p2p_receive_transaction.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ func (c *Configuration) p2pReceiveBeefTx(w http.ResponseWriter, req *http.Reques
}

var err error
if err = c.actions.ExecuteSimplifiedPaymentVerification(req.Context(), beefData); err != nil {
if err = ExecuteSimplifiedPaymentVerification(req.Context(), beefData); err != nil {
ErrorResponse(w, ErrorSimplifiedPaymentVerification, err.Error(), http.StatusExpectationFailed)
return
}
Expand Down
14 changes: 14 additions & 0 deletions server/simple_payment_verification.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package server

import (
"context"

"github.com/bitcoin-sv/go-paymail"
)

// ExecuteSimplifiedPaymentVerification verifies the inbound transaction (SPV).
// At the moment there are no sufficient requirements for its implementation.
func ExecuteSimplifiedPaymentVerification(ctx context.Context, beedData *paymail.DecodedBEEF) error {

return nil
}
Loading