add sign unsigned and check for uncomputed change

CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file. The format
 ## Table of Contents
 
 - [Unreleased](#unreleased)
+- [1.1.7 - 2024-09-10](#117---2024-09-10)
 - [1.1.6 - 2024-09-09](#116---2024-09-09)
 - [1.1.5 - 2024-09-06](#115---2024-09-06)
 - [1.1.4 - 2024-09-05](#114---2024-09-05)
@@ -14,6 +15,16 @@ All notable changes to this project will be documented in this file. The format
 - [1.1.0 - 2024-08-19](#110---2024-08-19)
 - [1.0.0 - 2024-06-06](#100---2024-06-06)
 
+
+## [1.1.7] - 2024-09-10
+  - Introduce `tx.ShallowClone()` 
+  - Introduce SignUnsigned to sign only inputs that have not already been signed
+  - Other minor performance improvements.
+
+  ### Added
+  - New method `Transaction.ShallowClone()`
+  - New method `Transaction.SignUnsigned()`
+
 ## [1.1.6] - 2024-09-09
   - Optimize handling of source transaction inputs. Avoid mocking up entire transaction when adding source inputs.
   - Minor alignment in ECIES helper function

transaction/transaction.go

@@ -12,6 +12,7 @@ import (
 	crypto "github.com/bitcoin-sv/go-sdk/primitives/hash"
 	"github.com/bitcoin-sv/go-sdk/script"
 	"github.com/bitcoin-sv/go-sdk/util"
+	"github.com/pkg/errors"
 )
 
 type Transaction struct {
@@ -325,7 +326,6 @@ func (tx *Transaction) Clone() *Transaction {
 		if input.SourceTransaction != nil {
 			clone.Inputs[i].SourceTransaction = input.SourceTransaction.Clone()
 		}
-		// clone.Inputs[i].SourceTransaction = input.SourceTransaction
 		clone.Inputs[i].sourceOutput = input.sourceOutput
 	}
 
@@ -437,6 +437,7 @@ func (tx *Transaction) AddMerkleProof(bump *MerklePath) error {
 }
 
 func (tx *Transaction) Sign() error {
+	tx.checkFeeCompluted()
 	for vin, i := range tx.Inputs {
 		if i.UnlockingScriptTemplate != nil {
 			unlock, err := i.UnlockingScriptTemplate.Sign(tx, uint32(vin))
@@ -448,3 +449,29 @@ func (tx *Transaction) Sign() error {
 	}
 	return nil
 }
+
+func (tx *Transaction) SignUnsigned() error {
+	tx.checkFeeCompluted()
+	for vin, i := range tx.Inputs {
+		if i.UnlockingScript == nil {
+			if i.UnlockingScriptTemplate != nil {
+				unlock, err := i.UnlockingScriptTemplate.Sign(tx, uint32(vin))
+				if err != nil {
+					return err
+				}
+				i.UnlockingScript = unlock
+			}
+		}
+	}
+	return nil
+}
+
+func (tx *Transaction) checkFeeCompluted() error {
+	for _, out := range tx.Outputs {
+		if out.Satoshis == 0 {
+			if out.Change {
+				return errors.New("There are still change outputs with uncomputed amounts. Use the Fee() method to compute the change amounts and transaction fees prior to signing.")
+			}
+		}
+	}
+}