Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shamir key share split & combine #45

Merged
merged 31 commits into from
Sep 4, 2024
Merged

shamir key share split & combine #45

merged 31 commits into from
Sep 4, 2024

Conversation

rohenaz
Copy link
Collaborator

@rohenaz rohenaz commented Aug 19, 2024 •
edited
Loading

  • add polynomial
  • add split method to PrivateKey
  • add shares method to PrivateKey
  • add test vectors from ts
  • return decoding errors for base58
  • linting
  • add example(s)
  • added recommended vscode plugin and extension settings for sonar in .vscode directory
  • update changelog

Reference from TS implementation: https://github.com/bitcoin-sv/ts-sdk/pull/108/files

@rohenaz rohenaz changed the title shamir secret key share split & combine shamir key share split & combine Aug 19, 2024
@rohenaz
Merge remote-tracking branch 'origin/master' into feature/shamir-key-…
062e8ad 
…split-combine
@rohenaz
implement new methods on PrivateKey for split/combine key shares, add…
357a4cb 
… tests
@rohenaz
remove comments, add additional tests
0f4d1f7
@rohenaz
resolve linting issues
564cdbe
@rohenaz
improve readability of NewKeySharesFromBackup
6af7893
@rohenaz
use correct format specifier for error
c464f11
@rohenaz
test invalid share values
489af51
@rohenaz
add tests for constrains on shares vs threshold
deb8bad
@rohenaz
declare common constant for polynomial create failure
77bd468
@rohenaz
add publicKey.ToHex() matching ts implementation, refactor decode sha…
992fff1 
…re to use polynomial point from string
@rohenaz
add bignumber and umod. return error from decode base58
e50ef48
@rohenaz
align umod, add more tests, static reconstruct
37ae6b6
@rohenaz
fix pointer issue in valueAt
c2d6345
@rohenaz
rename shamir -> keyshares. update changelog
1643a5f
@rohenaz
move bignumber random and umod to util package big.go
4bdd76e
@rohenaz
update changelog
8a41c44
@rohenaz
add backup and restore keyshares examples
feb300d
@rohenaz rohenaz marked this pull request as ready for review September 3, 2024 17:40
@rohenaz rohenaz requested a review from shruggr September 3, 2024 18:25
@rohenaz rohenaz assigned rohenaz and unassigned shruggr Sep 3, 2024
sirdeggen
sirdeggen approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@sirdeggen sirdeggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Maybe we should update the example code to use the FromBackupShares and ToBackupShares rather than showing the intermediate step.

The goal is to illustrate how simple the solution is for the application developer.

Approved none the less. Thanks for this.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rohenaz rohenaz merged commit 7876bc5 into master Sep 4, 2024
4 checks passed
@rohenaz rohenaz deleted the feature/shamir-key-split-combine branch October 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirdeggen sirdeggen sirdeggen approved these changes

@shruggr shruggr Awaiting requested review from shruggr

Assignees

@rohenaz rohenaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohenaz @sirdeggen @shruggr