Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Transaction.SignUnsigned #51

Merged
merged 10 commits into from
Sep 10, 2024
Merged

add Transaction.SignUnsigned #51

merged 10 commits into from
Sep 10, 2024

Conversation

rohenaz
Copy link
Collaborator

@rohenaz rohenaz commented Sep 10, 2024

  • check for uncomputed change when signing
  • add method to sign unsigned inputs only to align with feature in the pyton sdk

Fixes #40

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rohenaz rohenaz merged commit e3fc117 into master Sep 10, 2024
4 checks passed
@rohenaz rohenaz deleted the feature/sign-unsigned branch October 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Python SDK improved the signing function such that you can skip overwriting
1 participant
@rohenaz