Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SPV-846): refactor examples to show extended errors #249

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Refactor examples to show extended errors
  • Refactor methods which still return simple errors

@pawellewandowski98 pawellewandowski98 self-assigned this Jul 9, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner July 9, 2024 10:39
Copy link

github-actions bot commented Jul 9, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
errors.go Outdated Show resolved Hide resolved
@chris-4chain
Copy link
Contributor

testing πŸ§ͺ

@chris-4chain chris-4chain added the tested PR was tested by a team member label Jul 23, 2024
@pawellewandowski98 pawellewandowski98 merged commit c1170bf into main Jul 23, 2024
9 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-846-refactor-examples branch July 23, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants