Attempt to safe gaurd int conversions

bitcoin-sv · Mar 28, 2022 · 8608536 · 8608536
1 parent b116f98
commit 8608536
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/gqlgen/int.go b/gqlgen/int.go
@@ -2,8 +2,10 @@ package gqlgen
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
+	"math"
 	"strconv"
 
 	"github.com/99designs/gqlgen/graphql"
@@ -33,7 +35,10 @@ func UnmarshalInt16(v interface{}) (int16, error) {
 		if err != nil {
 			return 0, err
 		}
-		return int16(u64), err
+		if u64 <= math.MaxUint16 {
+			return int16(u64), err
+		}
+		return 0, errors.New("value is > math.MaxUint16")
 	default:
 		return 0, fmt.Errorf("%T is not an int16", v)
 	}

diff --git a/gqlgen/uint.go b/gqlgen/uint.go
@@ -2,8 +2,10 @@ package gqlgen
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
+	"math"
 	"strconv"
 
 	"github.com/99designs/gqlgen/graphql"
@@ -31,7 +33,10 @@ func UnmarshalUint(v interface{}) (uint, error) {
 		if err != nil {
 			return 0, err
 		}
-		return uint(u64), err
+		if u64 <= math.MaxUint {
+			return uint(u64), err
+		}
+		return 0, errors.New("value is > math.MaxUint")
 	default:
 		return 0, fmt.Errorf("%T is not an uint", v)
 	}