Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BUX-147): integrate go-broadcast-client #287

Merged
merged 4 commits into from
Aug 24, 2023
Merged

feat(BUX-147): integrate go-broadcast-client #287

merged 4 commits into from
Aug 24, 2023

Conversation

pawellewandowski98
Copy link
Contributor

Description

  • Integrate go-broadcast-client

Additional links

DO NOT MERGE

Wait for BUX PR

@mergify mergify bot added the feature Any new significant addition label Aug 23, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023

Welcome to our open-source project @pawellewandowski98! 💘

Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed, probably missing the Bux PR.

@pawellewandowski98
Copy link
Contributor Author

Tests failed, probably missing the Bux PR.

@mrz1836 Yes, when the new BUX version will be released, I will update it in go.mod and then tests should succeed.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #287 (8f038b1) into master (5e13afb) will increase coverage by 1.03%.
The diff coverage is 82.75%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   32.48%   33.52%   +1.03%     
==========================================
  Files          41       41              
  Lines        1382     1411      +29     
==========================================
+ Hits          449      473      +24     
- Misses        909      913       +4     
- Partials       24       25       +1     
Flag Coverage Δ
unittests 33.52% <82.75%> (+1.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
config/config.go 100.00% <ø> (ø)
config/services.go 38.64% <82.75%> (+4.80%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e13afb...8f038b1. Read the comment docs.

@mrz1836
Copy link
Contributor

mrz1836 commented Aug 24, 2023

Merge conflict, probably with the bux version vs dependabot. @pawellewandowski98

Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 4b66af9 into bitcoin-sv:master Aug 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants