-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BUX-147): integrate go-broadcast-client #287
feat(BUX-147): integrate go-broadcast-client #287
Conversation
Welcome to our open-source project @pawellewandowski98! 💘 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failed, probably missing the Bux PR.
@mrz1836 Yes, when the new BUX version will be released, I will update it in go.mod and then tests should succeed. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 32.48% 33.52% +1.03%
==========================================
Files 41 41
Lines 1382 1411 +29
==========================================
+ Hits 449 473 +24
- Misses 909 913 +4
- Partials 24 25 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Merge conflict, probably with the bux version vs dependabot. @pawellewandowski98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Additional links
DO NOT MERGE
Wait for BUX PR