Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BUX-218): do not send access key revoked at if it is not revoked #296

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(BUX-218): do not send access key revoked at if it is not revoked #296

merged 2 commits into from
Sep 8, 2023

Conversation

dorzepowski
Copy link
Contributor

@dorzepowski dorzepowski commented Sep 8, 2023

ℹ️ depends on changes in bux-models

@mergify mergify bot assigned mrz1836 Sep 8, 2023
@mergify mergify bot added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Sep 8, 2023
Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836
Copy link
Contributor

mrz1836 commented Sep 8, 2023

@dorzepowski @wregulski @vitalibalashka there is a merge conflict that needs to be resolved.

Copy link
Contributor

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict needs to be resolved

@dorzepowski
Copy link
Contributor Author

dorzepowski commented Sep 8, 2023

@dorzepowski @wregulski @vitalibalashka there is a merge conflict that needs to be resolved.

@mrz1836 Conflict resolved

@mrz1836
Copy link
Contributor

mrz1836 commented Sep 8, 2023

Thanks @dorzepowski but looks like you need to run make update or something similar, the go.sum is not liking the bux models new version

@dorzepowski
Copy link
Contributor Author

Thanks @dorzepowski but looks like you need to run make update or something similar, the go.sum is not liking the bux models new version

@mrz1836 right, I can't do that previously, because v0.2.0 doesn't exist, now it is updated

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #296 (58da7b6) into master (a7d34e1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files          42       42           
  Lines        1425     1425           
=======================================
  Hits          473      473           
  Misses        927      927           
  Partials       25       25           
Flag Coverage Δ
unittests 33.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d34e1...58da7b6. Read the comment docs.

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BuxOrg).

@mrz1836 mrz1836 merged commit 6a01236 into bitcoin-sv:master Sep 8, 2023
7 checks passed
@dorzepowski dorzepowski deleted the fix/bux-218-access-key-revoked-at branch September 11, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants