-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BUX-218): do not send access key revoked at if it is not revoked #296
fix(BUX-218): do not send access key revoked at if it is not revoked #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dorzepowski @wregulski @vitalibalashka there is a merge conflict that needs to be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict needs to be resolved
@mrz1836 Conflict resolved |
Thanks @dorzepowski but looks like you need to run |
@mrz1836 right, I can't do that previously, because v0.2.0 doesn't exist, now it is updated |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 33.19% 33.19%
=======================================
Files 42 42
Lines 1425 1425
=======================================
Hits 473 473
Misses 927 927
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
ℹ️ depends on changes in bux-models