feat(BUX-170): add pulse config #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to our open-source project @pawellewandowski98! 💘 |
pawellewandowski98
force-pushed
the
feat-add-Pulse-config
branch
from
39a9b2b
to
de49aeb
Compare
pawellewandowski98
requested review from
proapi,
mwilkosinski,
dorzepowski,
wregulski,
witalij-4chain,
kuba-4chain and
arkadiuszos4chain
and removed request for
a team
kuba-4chain
approved these changes
Oct 5, 2023
dorzepowski
requested changes
Oct 6, 2023
config/services.go
Outdated
| @@ -246,6 +246,15 @@ func (s *AppServices) loadBux(ctx context.Context, appConfig *AppConfig, testMod | |||
| )) | |||
| } | |||
|
|
|||
| if appConfig.UseBeef { | |||
|
|
|||
| if appConfig.Pulse == nil || appConfig.Pulse.PulseURL == "" || appConfig.Pulse.PulseAuthToken == "" { | |||
There was a problem hiding this comment.
Actually PulseAuthToken shouldn't be required. Because you can deploy Pulse without authorization.
config/envs/development.json
Outdated
| "use_beef": true, | ||
| "pulse": { | ||
| "pulse_url": "http://localhost:8000/api/v1/chain/merkleroot/verify", | ||
| "pulse_auth_token": "Bearer asd" |
There was a problem hiding this comment.
this is counterintuitive that we should provide prefix Bearer in a token configuration
pawellewandowski98
changed the title
dorzepowski
approved these changes
Oct 6, 2023
kuba-4chain
approved these changes
Oct 6, 2023
pawellewandowski98
force-pushed
the
feat-add-Pulse-config
branch
from
d703113
to
a4e860d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 33.21% 33.98% +0.76%
==========================================
Files 42 42
Lines 1424 1430 +6
==========================================
+ Hits 473 486 +13
+ Misses 926 919 -7
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional links