-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BUX-170): add pulse config #313
Conversation
Welcome to our open-source project @pawellewandowski98! 💘 |
39a9b2b
to
de49aeb
Compare
config/services.go
Outdated
@@ -246,6 +246,15 @@ func (s *AppServices) loadBux(ctx context.Context, appConfig *AppConfig, testMod | |||
)) | |||
} | |||
|
|||
if appConfig.UseBeef { | |||
|
|||
if appConfig.Pulse == nil || appConfig.Pulse.PulseURL == "" || appConfig.Pulse.PulseAuthToken == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually PulseAuthToken shouldn't be required. Because you can deploy Pulse without authorization.
config/envs/development.json
Outdated
"use_beef": true, | ||
"pulse": { | ||
"pulse_url": "http://localhost:8000/api/v1/chain/merkleroot/verify", | ||
"pulse_auth_token": "Bearer asd" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is counterintuitive that we should provide prefix Bearer
in a token configuration
d703113
to
a4e860d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 33.21% 33.98% +0.76%
==========================================
Files 42 42
Lines 1424 1430 +6
==========================================
+ Hits 473 486 +13
+ Misses 926 919 -7
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Description
Additional links