Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-809): mysql & mongo removal #598

Merged
merged 5 commits into from
May 24, 2024
Merged

feat(SPV-809): mysql & mongo removal #598

merged 5 commits into from
May 24, 2024

Conversation

wregulski
Copy link
Contributor

@wregulski wregulski commented May 23, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@wregulski wregulski self-assigned this May 23, 2024
@wregulski wregulski requested a review from a team as a code owner May 23, 2024 14:22
@wregulski wregulski marked this pull request as draft May 23, 2024 14:22
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @Nazarii-4chain resulted in success.

@wregulski wregulski added the feature Any new significant addition label May 23, 2024
@wregulski wregulski marked this pull request as ready for review May 23, 2024 15:11
@wregulski wregulski changed the title DRAFT: feat(SPV-XXX): mysql & mongo removal feat(SPV-XXX): mysql & mongo removal May 23, 2024
chris-4chain
chris-4chain approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@chris-4chain chris-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🚀
One thing which I've mentioned, can be done in separate task, I guess 😄

engine/go.mod Show resolved Hide resolved
@wregulski wregulski changed the title feat(SPV-XXX): mysql & mongo removal feat(SPV-809): mysql & mongo removal May 24, 2024
@Nazarii-4chain Nazarii-4chain added the tested PR was tested by a team member label May 24, 2024
@wregulski wregulski merged commit f20b3b0 into main May 24, 2024
8 of 9 checks passed
@wregulski wregulski deleted the feat/remove-mongo-mysql branch May 24, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees

@wregulski wregulski

Labels
feature Any new significant addition tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wregulski @chris-4chain @Nazarii-4chain