Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-737) unify search object & filters and move to models package #603

Merged
merged 13 commits into from
Jun 3, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented May 29, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented May 29, 2024

Manual Tests

πŸ’š Manual testing by @pawellewandowski98 resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 49.19%. Comparing base (cf3d33a) to head (185d2e9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   49.33%   49.19%   -0.15%     
==========================================
  Files         255      258       +3     
  Lines       12018    12051      +33     
==========================================
- Hits         5929     5928       -1     
- Misses       5505     5530      +25     
- Partials      584      593       +9     
Flag Coverage Ξ”
unittests 49.19% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
actions/contacts/models.go 0.00% <ΓΈ> (ΓΈ)
docs/docs.go 0.00% <ΓΈ> (ΓΈ)
engine/model_contact.go 64.66% <ΓΈ> (-0.24%) ⬇️
actions/common/search_methods.go 0.00% <0.00%> (ΓΈ)
actions/access_keys/count.go 0.00% <0.00%> (ΓΈ)
actions/destinations/count.go 0.00% <0.00%> (ΓΈ)
actions/transactions/count.go 0.00% <0.00%> (ΓΈ)
actions/utxos/count.go 0.00% <0.00%> (ΓΈ)
models/filter/contact_filter.go 0.00% <0.00%> (ΓΈ)
models/filter/destination_filter.go 75.00% <0.00%> (-25.00%) ⬇️
... and 22 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update cf3d33a...185d2e9. Read the comment docs.

@chris-4chain chris-4chain marked this pull request as ready for review May 29, 2024 12:17
@chris-4chain chris-4chain requested a review from a team as a code owner May 29, 2024 12:17
actions/admin/access_keys.go Outdated Show resolved Hide resolved
actions/admin/access_keys.go Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 added the tested PR was tested by a team member label May 31, 2024
@chris-4chain
Copy link
Contributor Author

chris-4chain commented May 31, 2024

We've faced an unexpected problem with mAPI during tests. Most probably, some test(s) depend on external mAPI provider which was down when GH ran tests.

I'll re-run tests later and check if the problem still exists.
I decided not to fix this issue because we're removing the mAPI support anyway.

@chris-4chain chris-4chain merged commit 717f7d3 into main Jun 3, 2024
13 checks passed
@chris-4chain chris-4chain deleted the refactor-737-search-object-to-models branch June 3, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants