Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-815): refactor how the outputs in draft transaction are created #608

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Jun 3, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner June 3, 2024 11:08
Copy link

github-actions bot commented Jun 3, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@pawellewandowski98 pawellewandowski98 force-pushed the feat-815-refactor-outputs-creation branch 3 times, most recently from 4329540 to da07b89 Compare June 5, 2024 11:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 48.91%. Comparing base (a53cf1e) to head (6c66ecd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
+ Coverage   48.86%   48.91%   +0.04%     
==========================================
  Files         259      259              
  Lines       12137    12160      +23     
==========================================
+ Hits         5931     5948      +17     
- Misses       5612     5616       +4     
- Partials      594      596       +2     
Flag Coverage Ξ”
unittests 48.91% <66.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
engine/action_transaction.go 36.27% <0.00%> (-0.36%) ⬇️
engine/model_draft_transactions.go 75.96% <68.62%> (+0.61%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a53cf1e...6c66ecd. Read the comment docs.

Copy link
Contributor

@Nazarii-4chain Nazarii-4chain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine/model_draft_transactions.go Outdated Show resolved Hide resolved
engine/model_draft_transactions.go Outdated Show resolved Hide resolved
engine/model_draft_transactions.go Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 force-pushed the feat-815-refactor-outputs-creation branch from 6c66ecd to 638b143 Compare June 7, 2024 10:49
@chris-4chain chris-4chain added the tested PR was tested by a team member label Jun 7, 2024
@pawellewandowski98 pawellewandowski98 merged commit 3114e9e into main Jun 7, 2024
13 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-815-refactor-outputs-creation branch June 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants