Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing dependencies issues #614

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented Jun 4, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@ac4ch ac4ch requested a review from a team as a code owner June 4, 2024 04:49
Copy link

github-actions bot commented Jun 4, 2024

Manual Tests

πŸ’š Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 49.19%. Comparing base (1e4c028) to head (0feedb7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   49.19%   49.19%           
=======================================
  Files         258      258           
  Lines       12051    12051           
=======================================
  Hits         5928     5928           
  Misses       5530     5530           
  Partials      593      593           
Flag Coverage Ξ”
unittests 49.19% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 1e4c028...0feedb7. Read the comment docs.

@dorzepowski dorzepowski added the tested PR was tested by a team member label Jun 4, 2024
@ac4ch ac4ch merged commit 64b1b30 into main Jun 4, 2024
8 of 9 checks passed
@ac4ch ac4ch deleted the chore/update-dependencies-mrz1836-spf13 branch June 4, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants