Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spv-827) switch contacts capability from brfc temporary pike to brfc pike.invite #616

Conversation

ac4ch
Copy link
Contributor

@ac4ch ac4ch commented Jun 7, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Jun 7, 2024

Manual Tests

πŸ’š Manual testing by @pawellewandowski98 resulted in success.

@ac4ch ac4ch changed the title Feat spv 827 switch contacts capability from brfc temporary pike to brfc pike.invite feat(spv-827) switch contacts capability from brfc temporary pike to brfc pike.invite Jun 7, 2024
ac4ch and others added 5 commits June 7, 2024 11:35
…aryPike-to-BRFCPike.invite' of github.com:bitcoin-sv/spv-wallet into feat-spv-827-Switch-Contacts-capability-from-BRFCTemporaryPike-to-BRFCPike.invite
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 48.86%. Comparing base (a53cf1e) to head (5577b08).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   48.86%   48.86%           
=======================================
  Files         259      259           
  Lines       12137    12137           
=======================================
  Hits         5931     5931           
  Misses       5612     5612           
  Partials      594      594           
Flag Coverage Ξ”
unittests 48.86% <100.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
engine/paymail_servant.go 57.14% <100.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a53cf1e...5577b08. Read the comment docs.

@ac4ch ac4ch marked this pull request as ready for review June 7, 2024 10:25
@ac4ch ac4ch requested a review from a team as a code owner June 7, 2024 10:25
engine/go.mod Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 added the tested PR was tested by a team member label Jun 7, 2024
@ac4ch ac4ch merged commit ae184d8 into main Jun 7, 2024
13 checks passed
@ac4ch ac4ch deleted the feat-spv-827-Switch-Contacts-capability-from-BRFCTemporaryPike-to-BRFCPike.invite branch June 7, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants