-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-846): refactor numeric error codes into strings #627
feat(SPV-846): refactor numeric error codes into strings #627
Conversation
Manual Testsπ Manual testing by @chris-4chain resulted in success. |
9fd9175
to
bfd73e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 48.83% 48.89% +0.05%
==========================================
Files 257 259 +2
Lines 11524 11531 +7
==========================================
+ Hits 5628 5638 +10
+ Misses 5312 5309 -3
Partials 584 584
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
c504b0f
to
f9172bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except that one file all seems to be good i would say
62c6f90
to
235969b
Compare
Pull Request Checklist
Description
Example:
request does not have auth header
Set error response by method from spverrors package
Error defined in ./spverrors/errors.go
Response with status 401:
If error is not defined in map we return default error: