Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-848) notifications #630

Merged
merged 37 commits into from
Jul 12, 2024
Merged

feat(SPV-848) notifications #630

merged 37 commits into from
Jul 12, 2024

Conversation

chris-4chain
Copy link
Contributor

@chris-4chain chris-4chain commented Jun 28, 2024

The new notifications system. Services/communication design is presented in Figma: https://www.figma.com/board/vLAeCMBiDij5WVryogIFOo/notifications?node-id=0-1&t=c1Y7DoGsjnguEZu8-1

It's tightly related to the webhook client (event receiver) introduced in go-client:
bitcoin-sv/spv-wallet-go-client#246

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Copy link

github-actions bot commented Jun 28, 2024

Manual Tests

💚 Manual testing by @pawellewandowski98 resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.00000% with 216 lines in your changes missing coverage. Please review.

Project coverage is 48.76%. Comparing base (ac3ad4e) to head (5889633).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   48.88%   48.76%   -0.12%     
==========================================
  Files         259      263       +4     
  Lines       11536    11827     +291     
==========================================
+ Hits         5639     5768     +129     
- Misses       5313     5467     +154     
- Partials      584      592       +8     
Flag Coverage Δ
unittests 48.76% <46.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
actions/admin/routes.go 100.00% <100.00%> (ø)
config/config.go 100.00% <ø> (ø)
config/defaults.go 100.00% <100.00%> (ø)
config/services.go 51.82% <100.00%> (+0.80%) ⬆️
docs/docs.go 0.00% <ø> (ø)
engine/model_destinations.go 59.21% <ø> (-0.10%) ⬇️
engine/models_internal.go 79.10% <ø> (+0.15%) ⬆️
engine/sync_tx_service.go 37.28% <ø> (-0.28%) ⬇️
engine/client.go 65.15% <60.00%> (+0.44%) ⬆️
engine/notifications/notifications.go 93.93% <93.93%> (+22.06%) ⬆️
... and 9 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3ad4e...5889633. Read the comment docs.

@chris-4chain chris-4chain marked this pull request as ready for review July 2, 2024 08:54
@chris-4chain chris-4chain requested a review from a team as a code owner July 2, 2024 08:54
engine/client.go Outdated Show resolved Hide resolved
engine/client.go Outdated Show resolved Hide resolved
engine/client_internal.go Outdated Show resolved Hide resolved
engine/client_internal.go Outdated Show resolved Hide resolved
engine/client_options.go Outdated Show resolved Hide resolved
engine/notifications/event_definitions.go Outdated Show resolved Hide resolved
engine/notifications/mock_sender.go Outdated Show resolved Hide resolved
engine/notifications/webhook_manager.go Outdated Show resolved Hide resolved
engine/notifications/webhook_manager.go Outdated Show resolved Hide resolved
engine/notifications/webhook_manager.go Outdated Show resolved Hide resolved
actions/admin/webhooks.go Outdated Show resolved Hide resolved
actions/admin/webhooks.go Outdated Show resolved Hide resolved
engine/client_internal.go Outdated Show resolved Hide resolved
engine/client_internal.go Show resolved Hide resolved
engine/model_webhook.go Outdated Show resolved Hide resolved
actions/admin/routes.go Outdated Show resolved Hide resolved
engine/models_test.go Show resolved Hide resolved
engine/db_model_transactions.go Outdated Show resolved Hide resolved
engine/notifications/notifications.go Outdated Show resolved Hide resolved
engine/client_test.go Outdated Show resolved Hide resolved
actions/admin/routes.go Outdated Show resolved Hide resolved
actions/admin/webhooks.go Outdated Show resolved Hide resolved
actions/admin/webhooks.go Outdated Show resolved Hide resolved
engine/client_internal.go Outdated Show resolved Hide resolved
engine/model_webhook.go Outdated Show resolved Hide resolved
engine/model_webhook.go Outdated Show resolved Hide resolved
engine/model_webhook.go Outdated Show resolved Hide resolved
engine/notifications/notifications.go Outdated Show resolved Hide resolved
engine/spverrors/definitions.go Outdated Show resolved Hide resolved
engine/model_webhook.go Outdated Show resolved Hide resolved
engine/model_webhook.go Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 added the tested PR was tested by a team member label Jul 12, 2024
@chris-4chain chris-4chain added the feature Any new significant addition label Jul 12, 2024
@chris-4chain chris-4chain merged commit 9814cfb into main Jul 12, 2024
13 checks passed
@chris-4chain chris-4chain deleted the feat-848-notifications branch July 12, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any new significant addition tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants