-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-848) notifications #630
Conversation
Manual Tests💚 Manual testing by @pawellewandowski98 resulted in success. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
- Coverage 48.88% 48.76% -0.12%
==========================================
Files 259 263 +4
Lines 11536 11827 +291
==========================================
+ Hits 5639 5768 +129
- Misses 5313 5467 +154
- Partials 584 592 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
f3156fd
to
d2b4af7
Compare
The new notifications system. Services/communication design is presented in Figma: https://www.figma.com/board/vLAeCMBiDij5WVryogIFOo/notifications?node-id=0-1&t=c1Y7DoGsjnguEZu8-1
It's tightly related to the webhook client (event receiver) introduced in
go-client
:bitcoin-sv/spv-wallet-go-client#246
Pull Request Checklist