Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SPV-929): allow to select version of services when using start.sh #645

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dorzepowski
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner July 9, 2024 10:57
Copy link

github-actions bot commented Jul 9, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 48.88%. Comparing base (f0e3f0d) to head (59621f3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   48.88%   48.88%           
=======================================
  Files         259      259           
  Lines       11536    11536           
=======================================
  Hits         5639     5639           
  Misses       5313     5313           
  Partials      584      584           
Flag Coverage Ξ”
unittests 48.88% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update f0e3f0d...59621f3. Read the comment docs.

@chris-4chain chris-4chain added the tested PR was tested by a team member label Jul 10, 2024
@dorzepowski dorzepowski merged commit ac3ad4e into main Jul 10, 2024
8 of 9 checks passed
@dorzepowski dorzepowski deleted the feat/spv-929-start-sh-choose-versions branch July 10, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants