Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SPV-1013): swaps errors to those in spverrors, bumps versions of imports #674

Conversation

jakubmkowalski
Copy link
Contributor

@jakubmkowalski jakubmkowalski commented Aug 23, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@jakubmkowalski jakubmkowalski requested a review from a team as a code owner August 23, 2024 12:26
Copy link

github-actions bot commented Aug 23, 2024

Manual Tests

πŸ’š Manual testing by @wregulski resulted in success.

@jakubmkowalski jakubmkowalski self-assigned this Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 49.01%. Comparing base (c1ebc7b) to head (c0fd17e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files         264      264           
  Lines       12226    12226           
=======================================
  Hits         5992     5992           
  Misses       5640     5640           
  Partials      594      594           
Flag Coverage Ξ”
unittests 49.01% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update c1ebc7b...c0fd17e. Read the comment docs.

@wregulski wregulski added the tested PR was tested by a team member label Aug 28, 2024
@jakubmkowalski jakubmkowalski merged commit 4541978 into main Aug 28, 2024
8 checks passed
@jakubmkowalski jakubmkowalski deleted the fix/SPV-1013-local-operator-fixes-after-spverrors-was-introduced branch August 28, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants