-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(SPV-1020): move paymail servant to separate package and use it in engine #697
Conversation
…it instead of functions from engine; Introduce better mocking API for testing with paymail operations.
Manual Tests💚 Manual testing by @chris-4chain resulted in success. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
+ Coverage 46.32% 46.42% +0.09%
==========================================
Files 290 296 +6
Lines 12833 13024 +191
==========================================
+ Hits 5945 6046 +101
- Misses 6296 6386 +90
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Please assign to PR :D |
Context
Pull Request Checklist