Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(SPV-1086): mock external dependencies in endpoint tests #732

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

dorzepowski
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner October 10, 2024 11:43
Copy link

github-actions bot commented Oct 10, 2024

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.

Project coverage is 45.82%. Comparing base (5d40daf) to head (8d79218).

Files with missing lines Patch % Lines
...ons/testabilities/fixture_spvwallet_application.go 0.00% 16 Missing ⚠️
config/config_to_options.go 0.00% 8 Missing ⚠️
engine/chain/chain_service.go 0.00% 1 Missing and 1 partial ⚠️
engine/client_options.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   45.93%   45.82%   -0.12%     
==========================================
  Files         322      322              
  Lines       13259    13276      +17     
==========================================
- Hits         6091     6084       -7     
- Misses       6605     6628      +23     
- Partials      563      564       +1     
Flag Coverage Δ
unittests 45.82% <12.90%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
engine/client.go 55.00% <ø> (-0.74%) ⬇️
engine/client_internal.go 65.35% <100.00%> (+0.22%) ⬆️
engine/client_options.go 68.81% <50.00%> (-1.65%) ⬇️
engine/chain/chain_service.go 60.00% <0.00%> (-40.00%) ⬇️
config/config_to_options.go 0.00% <0.00%> (ø)
...ons/testabilities/fixture_spvwallet_application.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d40daf...8d79218. Read the comment docs.

@dorzepowski dorzepowski added the regression-tests Runs regression tests label Oct 10, 2024
@chris-4chain chris-4chain added the tested PR was tested by a team member label Oct 10, 2024
@dorzepowski dorzepowski merged commit 1de1edc into main Oct 10, 2024
18 of 19 checks passed
@dorzepowski dorzepowski deleted the test/mocking-external-dependencies branch October 10, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants