Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SPV-1057): rename draft to transaction outlines in new tx flow. #739

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

dorzepowski
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner October 15, 2024 07:44
Copy link

github-actions bot commented Oct 15, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.62162% with 87 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (426c6c6) to head (4e3260b).

Files with missing lines Patch % Lines
...outlines/testabilities/assert_draft_transaction.go 0.00% 68 Missing ⚠️
...utlines/testabilities/fixture_draft_transaction.go 0.00% 10 Missing ⚠️
engine/client_transaction.go 0.00% 3 Missing ⚠️
...ansaction/outlines/transaction_outlines_service.go 50.00% 3 Missing ⚠️
...utlines/testabilities/ability_draft_transaction.go 0.00% 2 Missing ⚠️
engine/client.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   46.60%   46.60%           
=======================================
  Files         328      328           
  Lines       13378    13378           
=======================================
  Hits         6235     6235           
  Misses       6569     6569           
  Partials      574      574           
Flag Coverage Ξ”
unittests 46.60% <21.62%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
...ernal/mapping/outline/outline_request_to_engine.go 72.97% <100.00%> (ΓΈ)
...ns/internal/mapping/outline/outline_to_response.go 66.66% <100.00%> (ΓΈ)
actions/transactions/outlines.go 70.00% <100.00%> (ΓΈ)
engine/client_internal.go 65.35% <100.00%> (ΓΈ)
engine/client_options.go 67.84% <100.00%> (ΓΈ)
...ransaction/outlines/internal/evaluation/context.go 86.66% <ΓΈ> (ΓΈ)
engine/transaction/outlines/outputs/op_return.go 96.87% <100.00%> (ΓΈ)
engine/transaction/outlines/outputs/paymail.go 90.32% <100.00%> (ΓΈ)
engine/transaction/outlines/outputs/spec.go 100.00% <100.00%> (ΓΈ)
engine/transaction/outlines/transaction_spec.go 100.00% <100.00%> (ΓΈ)
... and 8 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 426c6c6...4e3260b. Read the comment docs.

@dorzepowski dorzepowski added the regression-tests Runs regression tests label Oct 17, 2024
@dorzepowski dorzepowski added regression-tests Runs regression tests and removed regression-tests Runs regression tests labels Oct 17, 2024
@chris-4chain chris-4chain added the tested PR was tested by a team member label Oct 17, 2024
@dorzepowski dorzepowski removed the regression-tests Runs regression tests label Oct 17, 2024
@dorzepowski dorzepowski enabled auto-merge (squash) October 17, 2024 13:07
@dorzepowski dorzepowski merged commit 3312ad9 into main Oct 17, 2024
8 checks passed
@dorzepowski dorzepowski deleted the refactor/rename-draft-to-transaction-outline branch October 17, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants