Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SPV-1101): wrong SQL alias _id in aggregate function (admin stats endpoint) #743

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

yarex-4chain
Copy link
Contributor

@yarex-4chain yarex-4chain commented Oct 17, 2024

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@yarex-4chain yarex-4chain added the bug-P3 Lowest rated bug, affects nearly none or low-impact label Oct 17, 2024
@yarex-4chain yarex-4chain self-assigned this Oct 17, 2024
@yarex-4chain yarex-4chain requested a review from a team as a code owner October 17, 2024 07:56
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

Copy link

github-actions bot commented Oct 17, 2024

Manual Tests

πŸ’š Manual testing by @wregulski resulted in success.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (3312ad9) to head (8325991).

Files with missing lines Patch % Lines
engine/datastore/models.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   46.60%   46.62%   +0.01%     
==========================================
  Files         328      328              
  Lines       13378    13378              
==========================================
+ Hits         6235     6237       +2     
+ Misses       6569     6567       -2     
  Partials      574      574              
Flag Coverage Ξ”
unittests 46.62% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
engine/datastore/models.go 0.00% <0.00%> (ΓΈ)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3312ad9...8325991. Read the comment docs.

@yarex-4chain yarex-4chain added the regression-tests Runs regression tests label Oct 17, 2024
@wregulski wregulski added the tested PR was tested by a team member label Oct 17, 2024
@yarex-4chain yarex-4chain added tested PR was tested by a team member and removed tested PR was tested by a team member labels Oct 17, 2024
@github-actions github-actions bot removed the tested PR was tested by a team member label Oct 17, 2024
@yarex-4chain yarex-4chain added the tested PR was tested by a team member label Oct 17, 2024
@github-actions github-actions bot removed the tested PR was tested by a team member label Oct 17, 2024
@wregulski wregulski added the tested PR was tested by a team member label Oct 18, 2024
@yarex-4chain yarex-4chain merged commit bbd1b05 into main Oct 18, 2024
11 checks passed
@yarex-4chain yarex-4chain deleted the fix/SPV-1101-admin-stats-endpoint-fix branch October 18, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-P3 Lowest rated bug, affects nearly none or low-impact regression-tests Runs regression tests tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants