Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address book sugestions #648

Closed
bitcoinuser opened this issue Nov 21, 2011 · 2 comments
Closed

Address book sugestions #648

bitcoinuser opened this issue Nov 21, 2011 · 2 comments
Labels
GUI Refactoring

Comments

@bitcoinuser
Copy link

Hi,

1- I think should be able to right click on the address to edit key or label information. (It took me a while to figure out the double click to edit)
2- I think when adding an address on address book, could have an option to add custom fields. We could add, rename and delete the fields.
@laanwj
Copy link
Member

laanwj commented Nov 29, 2011

Yes I think these are good suggestions.
(2) will require some changes to the core, but I've also proposed before that being able to attach arbitrary metadata to transactions/addresses would be useful.

@laanwj laanwj mentioned this issue Dec 4, 2011
Merged
laanwj added a commit to laanwj/bitcoin that referenced this issue Dec 23, 2011
@laanwj
Add context menu for address book page (implements part 1 of issue bi…
c4a4a4b 
…tcoin#648)
coblee referenced this issue in litecoin-project/litecoin Jul 17, 2012
@laanwj
Add context menu for address book page (implements part 1 of issue #648)
564234b
@laanwj
Copy link
Member

laanwj commented Apr 23, 2014

Closing this. Part 1 has been implemented already.

Adding additional information on an address does not sound useful to me as addresses are not meant to be reused.
(adding information on a transaction may be useful on the other hand... this is already what happens in the case of a payment request)

@laanwj laanwj closed this as completed Apr 23, 2014
kallewoof pushed a commit to kallewoof/bitcoin that referenced this issue Oct 4, 2019
@stevenroose
Merge bitcoin#648: Properly rename liquid windows binaries
89dd20a 
e045fcb Properly rename liquid windows binaries (Gregory Sanders)

Pull request description:

  resolves ElementsProject/elements#603

Tree-SHA512: c07c0185788a3c6a8f09df04bcfbf491b5ae7fd99ee4ab468b114414e32a5a969bc958274e02e10e6bc41e69352661465f5439e2040cdcdf5a5bc8cc1d74e423
sipa added a commit to sipa/bitcoin that referenced this issue Sep 11, 2020
@sipa
Squashed 'src/secp256k1/' changes from 2ed54da..8ab24e8
b9c1a76 
8ab24e8 Merge bitcoin#558: Add schnorrsig module which implements BIP-340 compliant signatures
f3733c5 Merge bitcoin#797: Fix Jacobi benchmarks and other benchmark improvements
cb5524a Add benchmark for secp256k1_ge_set_gej_var
5c6af60 Make jacobi benchmarks vary inputs
d0fdd5f Randomize the Z coordinates in bench_internal
c7a3424 Rename bench_internal variables
875d68b Merge bitcoin#699: Initialize field elements when resulting in infinity
54caf2e Merge bitcoin#799: Add fallback LE/BE for architectures with known endianness + SHA256 selftest
f431b3f valgrind_ctime_test: Add schnorrsig_sign
16ffa9d schnorrsig: Add taproot test case
8dfd53e schnorrsig: Add benchmark for sign and verify
4e43520 schnorrsig: Add BIP-340 compatible signing and verification
7332d2d schnorrsig: Add BIP-340 nonce function
7a703fd schnorrsig: Init empty experimental module
eabd9bc Allow initializing tagged sha256
6fcb5b8 extrakeys: Add keypair_xonly_tweak_add
5825446 extrakeys: Add keypair struct with create, pub and pub_xonly
f001034 Separate helper functions for pubkey_create and seckey_tweak_add
910d9c2 extrakeys: Add xonly_pubkey_tweak_add & xonly_pubkey_tweak_add_test
176bfb1 Separate helper function for ec_pubkey_tweak_add
4cd2ee4 extrakeys: Add xonly_pubkey with serialize, parse and from_pubkey
f49c989 Merge bitcoin#806: Trivial: Add test logs to gitignore
aabf00c Merge bitcoin#648: Prevent ints from wrapping around in scratch space functions
f5adab1 Merge bitcoin#805: Remove the extremely outdated TODO file.
bceefd6 Add test logs to gitignore
1c32519 Remove the extremely outdated TODO file.
47e6618 extrakeys: Init empty experimental module
3e08b02 Make the secp256k1_declassify argument constant
8bc6aef Add SHA256 selftest
670cdd3 Merge bitcoin#798: Check assumptions on integer implementation at compile time
5e5fb28 Use additional system macros to figure out endianness
7c06899 Compile-time check assumptions on integer types
02b6c87 Add support for (signed) __int128
979961c Merge bitcoin#787: Use preprocessor macros instead of autoconf to detect endianness
887bd1f Merge bitcoin#793: Make scalar/field choice depend on C-detected __int128 availability
0dccf98 Use preprocessor macros instead of autoconf to detect endianness
b2c8c42 Merge bitcoin#795: Avoid linking libcrypto in the valgrind ct test.
57d3a3c Avoid linking libcrypto in the valgrind ct test.
79f1f7a Autodetect __int128 availability on the C side
0d7727f Add SECP256K1_FE_STORAGE_CONST_GET to 5x52 field
805082d Merge bitcoin#696: Run a Travis test on s390x (big endian)
3929536 Test travis s390x (big endian)
6034a04 Merge bitcoin#778: secp256k1_gej_double_nonzero supports infinity
f609159 Merge bitcoin#779: travis: Fix argument quoting for ./configure
9e49a9b travis: Fix argument quoting for ./configure
18d3632 secp256k1_gej_double_nonzero supports infinity
214cb3c Merge bitcoin#772: Improve constant-timeness on PowerPC
40412b1 Merge bitcoin#774: tests: Abort if malloc() fails during context cloning tests
2e1b9e0 tests: Abort if malloc() fails during context cloning tests
67a429f Suppress a harmless variable-time optimization by clang in _int_cmov
5b19633 Remove redundant "? 1 : 0" after comparisons in scalar code
3e5cfc5 Merge bitcoin#741: Remove unnecessary sign variable from wnaf_const
66bb932 Merge bitcoin#773: Fix some compile problems on weird/old compilers.
1309c03 Fix some compile problems on weird/old compilers.
2309c7d Merge bitcoin#769: Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
22e578b Undef HAVE___INT128 in basic-config.h to fix gen_context compilation
3f4a5a1 Merge bitcoin#765: remove dead store in ecdsa_signature_parse_der_lax
f00d657 remove dead store in ecdsa_signature_parse_der_lax
dbd41db Merge bitcoin#759: Fix uninitialized variables in ecmult_multi test
2e7fc5b Fix uninitialized variables in ecmult_multi test
37dba32 Remove unnecessary sign variable from wnaf_const
6bb0b77 Fix test_constant_wnaf for -1 and add a test for it.
47a7b83 Clear field elements when writing infinity
61d1ecb Added test with additions resulting in infinity
60f7f2d Don't assume that ALIGNMENT > 1 in tests
ada6361 Use ROUND_TO_ALIGN in scratch_create
8ecc6ce Add check preventing rounding to alignment from wrapping around in scratch_alloc
4edaf06 Add check preventing integer multiplication wrapping around in scratch_max_allocation

git-subtree-dir: src/secp256k1
git-subtree-split: 8ab24e8
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this issue Aug 5, 2021
@pamelawjd
Update 02_getting_started (bitcoin#648)
1543451 
Moved Alice introduction paragraph to the beginning
Added TODO for link to bitcoin basics guide / fundamentals
Moved Testnet Bitcoin section to wallets
Added tip about Alice being able to transfer bitcoin she already owns to her new Eclair wallet
Fixed typo
Added language about Bob's perspective just before conclusion
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
GUI Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laanwj @bitcoinuser